Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9520

Remove calibrateTask.py example from Stack (for now)

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_tasks
    • Labels:
      None

      Description

      This is triggered by RFC-290, and will be comprised of 2 parts: actually removing calibrateTask from the current pipetasks examples dir, and then editing the doxygen docs so that the example is not referred to any further on the doxygen pages.

        Attachments

          Issue Links

            Activity

            No builds found.
            mssgill Mandeep Gill [X] (Inactive) created issue -
            mssgill Mandeep Gill [X] (Inactive) made changes -
            Field Original Value New Value
            Link This issue is triggered by RFC-290 [ RFC-290 ]
            tjenness Tim Jenness made changes -
            Team Data Release Production [ 10301 ]
            Hide
            mssgill Mandeep Gill [X] (Inactive) added a comment -

            Hi Tim- could you take a quick look and review this parallel one, also? Have removed this example and the docstrings in the actual calibrate.py and charImg here, too. Thx! -M

            Show
            mssgill Mandeep Gill [X] (Inactive) added a comment - Hi Tim- could you take a quick look and review this parallel one, also? Have removed this example and the docstrings in the actual calibrate.py and charImg here, too. Thx! -M
            mssgill Mandeep Gill [X] (Inactive) made changes -
            Reviewers Tim Jenness [ tjenness ]
            Status To Do [ 10001 ] In Review [ 10004 ]
            tjenness Tim Jenness made changes -
            Assignee Mandeep Gill [ mssgill ]
            tjenness Tim Jenness made changes -
            Watchers Mandeep Gill, Tim Jenness [ Mandeep Gill, Tim Jenness ] John Swinbank, Mandeep Gill, Tim Jenness [ John Swinbank, Mandeep Gill, Tim Jenness ]
            Hide
            tjenness Tim Jenness added a comment -

            This looks reasonable. Did you do a test build to make sure nothing weird has gone wrong with it?

            Show
            tjenness Tim Jenness added a comment - This looks reasonable. Did you do a test build to make sure nothing weird has gone wrong with it?
            tjenness Tim Jenness made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            Hide
            mssgill Mandeep Gill [X] (Inactive) added a comment - - edited

            Very reasonable q, and yes, i did a test build of the docs dir, and it checks out – the page for charImg and calib now both go straight from the Debug section to the description of the Constructor with the Example section cleanly excised, and looks just fine.

            Show
            mssgill Mandeep Gill [X] (Inactive) added a comment - - edited Very reasonable q, and yes, i did a test build of the docs dir, and it checks out – the page for charImg and calib now both go straight from the Debug section to the description of the Constructor with the Example section cleanly excised, and looks just fine.
            Hide
            tjenness Tim Jenness added a comment -

            Given that this PR was merged and that RFC-290 was closed, can you please also close this ticket?

            Show
            tjenness Tim Jenness added a comment - Given that this PR was merged and that RFC-290 was closed, can you please also close this ticket?
            swinbank John Swinbank made changes -
            Epic Link DM-8306 [ 27828 ]
            swinbank John Swinbank made changes -
            Sprint DRP S17-3 [ 360 ]
            swinbank John Swinbank made changes -
            Story Points 0.25
            tjenness Tim Jenness made changes -
            Component/s pipe_tasks [ 10726 ]
            Hide
            mssgill Mandeep Gill [X] (Inactive) added a comment - - edited

            Yep, thx for the reminder Tim Jenness – removal completed.

            Show
            mssgill Mandeep Gill [X] (Inactive) added a comment - - edited Yep, thx for the reminder Tim Jenness – removal completed.
            mssgill Mandeep Gill [X] (Inactive) made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            swinbank John Swinbank made changes -
            Link This issue relates to DM-9142 [ DM-9142 ]

              People

              Assignee:
              mssgill Mandeep Gill [X] (Inactive)
              Reporter:
              mssgill Mandeep Gill [X] (Inactive)
              Reviewers:
              Tim Jenness
              Watchers:
              John Swinbank, Mandeep Gill [X] (Inactive), Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.