Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9556

All NaNs in coord_ra and coord_dec columns in deepCoadd forced src tables

    Details

      Description

      In recent runs of the stack through multiBandDriver.py, the persisted forced src tables for the coadds are not getting ra and dec set properly (all entries for the coord_ra and coord_dec columns are NaN). Looking back at a run in mid-Nov, 2016, these numbers were indeed set properly in the forced tables. Assuming this was not intentional, track down the cause and fix it such that these values get set properly for the persisted forced src tables.

        Attachments

          Issue Links

            Activity

            Hide
            price Paul Price added a comment -

            Revised:

            -price@pap-laptop:~/LSST/meas_base (tickets/DM-9556=) $ git sub-patch
            commit 94f876db450f3494ff1ef8d737c696a4586f7836
            Author: Paul Price <price@astro.princeton.edu>
            Date:   Fri Mar 31 11:48:21 2017 -0400
             
                forcedMeasurement: copy coordinates, deblend_nChild
                
                Forced measurement catalogs currently have no RA,Dec or
                deblend_nChild. These used to be copied from the reference
                catalog, but commit 448121a4 removed this behaviour.
                Restoring it.
             
            diff --git a/python/lsst/meas/base/forcedMeasurement.py b/python/lsst/meas/base/forcedMeasurement.py
            index 52dcbb3..1c97858 100644
            --- a/python/lsst/meas/base/forcedMeasurement.py
            +++ b/python/lsst/meas/base/forcedMeasurement.py
            @@ -163,7 +163,8 @@ class ForcedMeasurementConfig(BaseMeasurementConfig):
             
                 copyColumns = lsst.pex.config.DictField(
                     keytype=str, itemtype=str, doc="Mapping of reference columns to source columns",
            -        default={"id": "objectId", "parent": "parentObjectId"}
            +        default={"id": "objectId", "parent": "parentObjectId", "deblend_nChild": "deblend_nChild",
            +                 "coord_ra": "coord_ra", "coord_dec": "coord_dec"}
                 )
             
                 checkUnitsParseStrict = lsst.pex.config.Field(
            

            Show
            price Paul Price added a comment - Revised: -price@pap-laptop:~/LSST/meas_base (tickets/DM-9556=) $ git sub-patch commit 94f876db450f3494ff1ef8d737c696a4586f7836 Author: Paul Price <price@astro.princeton.edu> Date: Fri Mar 31 11:48:21 2017 -0400   forcedMeasurement: copy coordinates, deblend_nChild Forced measurement catalogs currently have no RA,Dec or deblend_nChild. These used to be copied from the reference catalog, but commit 448121a4 removed this behaviour. Restoring it.   diff --git a/python/lsst/meas/base/forcedMeasurement.py b/python/lsst/meas/base/forcedMeasurement.py index 52dcbb3..1c97858 100644 --- a/python/lsst/meas/base/forcedMeasurement.py +++ b/python/lsst/meas/base/forcedMeasurement.py @@ -163,7 +163,8 @@ class ForcedMeasurementConfig(BaseMeasurementConfig): copyColumns = lsst.pex.config.DictField( keytype=str, itemtype=str, doc="Mapping of reference columns to source columns", - default={"id": "objectId", "parent": "parentObjectId"} + default={"id": "objectId", "parent": "parentObjectId", "deblend_nChild": "deblend_nChild", + "coord_ra": "coord_ra", "coord_dec": "coord_dec"} ) checkUnitsParseStrict = lsst.pex.config.Field(
            Hide
            price Paul Price added a comment -

            Also need:

            price@pap-laptop:~/LSST/meas_modelfit (tickets/DM-9556=) $ git sub
            commit f2c37e1e4543ce5b5ffe670d2c149d8c426ca6b9
            Author: Paul Price <price@astro.princeton.edu>
            Date:   Fri Mar 31 13:35:24 2017 -0400
             
                tests: adapt to ForcedMeasurementConfig changes
                
                ForcedMeasurementConfig now by default copies fields that aren't
                present in our basic test catalogs, so set the list of columns
                to copy to what we do have (the same setting as was default previously).
             
             tests/testDoubleShapeletPsfApprox.py         | 1 +
             tests/testGeneralShapeletPsfApproxPlugins.py | 1 +
             2 files changed, 2 insertions(+)
            

            Plus similar changes in meas_extensions_photometryKron.

            Show
            price Paul Price added a comment - Also need: price@pap-laptop:~/LSST/meas_modelfit (tickets/DM-9556=) $ git sub commit f2c37e1e4543ce5b5ffe670d2c149d8c426ca6b9 Author: Paul Price <price@astro.princeton.edu> Date: Fri Mar 31 13:35:24 2017 -0400   tests: adapt to ForcedMeasurementConfig changes ForcedMeasurementConfig now by default copies fields that aren't present in our basic test catalogs, so set the list of columns to copy to what we do have (the same setting as was default previously).   tests/testDoubleShapeletPsfApprox.py | 1 + tests/testGeneralShapeletPsfApproxPlugins.py | 1 + 2 files changed, 2 insertions(+) Plus similar changes in meas_extensions_photometryKron.
            Hide
            price Paul Price added a comment -

            Jim Bosch, there are four new changes to review, required in tests of forced measurement because we changed the defaults to require a field which isn't present without some extra effort. Changes are in meas_modelfit, meas_extensions_photometryKron, meas_extensions_convolved and pipe_tasks. They're pretty simple, but please have a quick look at them before I merge.

            Show
            price Paul Price added a comment - Jim Bosch , there are four new changes to review, required in tests of forced measurement because we changed the defaults to require a field which isn't present without some extra effort. Changes are in meas_modelfit, meas_extensions_photometryKron, meas_extensions_convolved and pipe_tasks. They're pretty simple, but please have a quick look at them before I merge.
            Hide
            jbosch Jim Bosch added a comment -

            Looks fine. Too bad it's so fragile, but I don't see a simple way to fix that, and it's certainly out of scope here.

            Show
            jbosch Jim Bosch added a comment - Looks fine. Too bad it's so fragile, but I don't see a simple way to fix that, and it's certainly out of scope here.
            Hide
            price Paul Price added a comment -

            Thanks Jim.

            Merged to master.

            Show
            price Paul Price added a comment - Thanks Jim. Merged to master.

              People

              • Assignee:
                price Paul Price
                Reporter:
                lauren Lauren MacArthur
                Reviewers:
                Jim Bosch
                Watchers:
                Jim Bosch, John Swinbank, Lauren MacArthur, Paul Price
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: