Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9564

Set assembled Coadd Psf to modelPsf with auto-computed dimensions

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ip_diffim, pipe_tasks
    • Labels:
      None

      Description

      DM-8088 changed makeCoaddTempExp so that the user no longer has to specify the pixel dimensions of the model PSF to match to. The model Psf dimensions are updated at runtime to match those of the warped calexp PSFs (which have dimensions impossible for a user to know ahead of time).

      AssembleCoadd currently attaches the PSF corresponding to the user-specified model PSF dimensions rather than the updated PSF-dimensions. This is bad because the user-specified dimensions could be way off and it's incongruous to tell users that they don't have to pay attention to this in makeCoaddTempExp, but they do in assembleCoadd.

      This ticket will ensure that the modelPsf dimension information flows down from the coaddTempExps to the assembled deeepCoadd in a sensible way. Most likely using the maximum dimensions of the input coaddTempExps.

        Attachments

          Activity

          Hide
          yusra Yusra AlSayyad added a comment -
          Show
          yusra Yusra AlSayyad added a comment - Bob Armstrong , do you have time to review? https://ci.lsst.codes/job/stack-os-matrix/22705/
          Hide
          rearmstr Bob Armstrong added a comment -

          Probably not till Monday, as I'm gone to a conference for the rest of the week.

          Show
          rearmstr Bob Armstrong added a comment - Probably not till Monday, as I'm gone to a conference for the rest of the week.
          Hide
          yusra Yusra AlSayyad added a comment -

          Lauren MacArthur, do you have time to review?

          Show
          yusra Yusra AlSayyad added a comment - Lauren MacArthur , do you have time to review?
          Hide
          lauren Lauren MacArthur added a comment -

          I put some comments on the PRs. I'm satisfied, but a second set of eyes is never a bad idea if Paul Price has a moment!

          Show
          lauren Lauren MacArthur added a comment - I put some comments on the PRs. I'm satisfied, but a second set of eyes is never a bad idea if Paul Price has a moment!
          Hide
          price Paul Price added a comment -

          It looks fine to me. I don't understand why max(dimList) works, but if you tell me it does then I believe you.

          Show
          price Paul Price added a comment - It looks fine to me. I don't understand why max(dimList) works, but if you tell me it does then I believe you.
          Hide
          lauren Lauren MacArthur added a comment -

          Tag team approves.

          Show
          lauren Lauren MacArthur added a comment - Tag team approves.

            People

            • Assignee:
              yusra Yusra AlSayyad
              Reporter:
              yusra Yusra AlSayyad
              Reviewers:
              Lauren MacArthur, Paul Price
              Watchers:
              Bob Armstrong, Lauren MacArthur, Paul Price, Yusra AlSayyad
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel