Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9601

Config.loadFromStream does not accept StringIO objects (and maybe files)

    XMLWordPrintable

Details

    • Bug
    • Status: Invalid
    • Resolution: Done
    • None
    • pex_config
    • None
    • 1
    • Architecture

    Description

      pex.config.Config.loadFromStream's documentation, name, and symmetry with saveToStream all state that it should accept arbitrary file-like objects, but (at least on Python 3) it appears to only accept strings, because it passes its first argument directly to exec, and that accepts only string or bytes objects.

      Attachments

        Issue Links

          Activity

            tjenness Tim Jenness added a comment -

            It looks like rowen was aware of this issue given the code comments associated with DM-3630 in commit fcf2f7d48b4409510552106a877c7ee533481f0b

            tjenness Tim Jenness added a comment - It looks like rowen was aware of this issue given the code comments associated with DM-3630 in commit fcf2f7d48b4409510552106a877c7ee533481f0b
            tjenness Tim Jenness added a comment -

            The documentation does seem to be lying about this still.

            tjenness Tim Jenness added a comment - The documentation does seem to be lying about this still.
            jbosch Jim Bosch added a comment -

            I somehow managed to rewrite this ticket almost verbatim almost 5 years later without remembering this one. Work has been done there, so I'm closing this as the duplicate.

            jbosch Jim Bosch added a comment - I somehow managed to rewrite this ticket almost verbatim almost 5 years later without remembering this one. Work has been done there, so I'm closing this as the duplicate.

            People

              Unassigned Unassigned
              jbosch Jim Bosch
              Jim Bosch, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.