Details
-
Type:
Bug
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: afw, Continuous Integration
-
Labels:
-
Team:SQuaRE
Description
Testing_pipeQA attempts to access 'cast_Raft()' which is no longer defined. It is used in two packages:
testing_pipeQA e.g.
./testing_pipeQA/python/lsst/testing/pipeQA/QaFigures.py: raft = cameraGeom.cast_Raft(r)
./testing_pipeQA/python/lsst/testing/pipeQA/figures/FpaQaFigure.py: raft = cameraGeom.cast_Raft(r)
./testing_pipeQA/python/lsst/testing/pipeQA/figures/QaFigureUtils.py: raft = cameraGeom.cast_Raft(r)
./testing_pipeQA/python/lsst/testing/pipeQA/CameraInfo.py: raft = cameraGeom.cast_Raft(r)
And
in afw/examples (a good reason why they should be periodically tested): e.g.
./afw/examples/showCamera.py: raft = cameraGeom.cast_Raft(raft)
Attachments
Issue Links
- relates to
-
DM-80 Refactor pipeQA for new cameraGeom
- Won't Fix
Activity
The unittest failure fix was tested on tickets/DM-961 using buildbot. That fix was to remove testing_pipeQA from the Release stack since it was not scheduled for integration with the cameraGeom upgrade in the near future.
The stack re-build was successfull – up until the next formerly hidden unittest failure was uncovered.
tickets/DM-961 is a branch on git.lsstcopr.org:LSST/DMS/lsst_distrib.git
There's not much code to review in the ticket. Read the last comment to get the package which was modified to effect the change: lsst_distrib/ups/lsst_distrib.table with the change being the removal of testing_pipeQA from the table.
Andy sent the following email on 14 July 2014:
A quick note on the pipeQA failure. This is due to the camera geometry update from Winter 2014; the pipeQA upgrade was captured by Simon as a Summer 2014 to-do in DM-80. This has cropped up a couple of times now (also DM-938). I would recommend closing DM-938 as a duplicate (or whatever the Jira equivalent), and it looks like the DM-961 fix was to remove pipeQA from the buildbot stack for now. This leaves DM-80 as the primary issue for upgrading pipeQA to use the new camera geometry. It is currently in the backlog, and competing for (probably Simon's) time.
I consider this a Review Complete for this trivial issue.
I took the following actions:
I made DM-938 a duplicate of DM-80. I have also noted DM-961 in DM-80's links and added a comment to remind the developer to reinstall testing_PipeQA when DM-80 ticket is fulfilled.
As Andy B says: this is a known issue. pipeQA has not yet been updated to work with the new cameraGeom. It should not be distributed with the stack until that is resolved.
In case someone is concerned that the whole stack wasn't working before this went into master...this error has been ignored by buildbot up until Thursday and up until that point, all the other packages and the old end-to-end test "worked".