Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9629

Research: how to implement spatially varying PSF for spatially-varying ZOGY and AL(decorrelated)

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ip_diffim
    • Labels:
      None

      Description

      The ImageMapReduceTask can compute diffims for both ZOGY and A&L decorrelation, including a spatially-varying PSF and variance plane. However, it does not construct a usable spatially-varying PSF that is optimal for detection and measurement. This story will involve research on how to implement such an object (potentially a subclass of CoaddPsf) and implementing it and computing it flexibly for ImageMapReduceTask.

        Attachments

          Issue Links

            Activity

            Hide
            reiss David Reiss added a comment -

            Implemented as a CoaddPsf. Seems to work well.

            Added to `ImageMapReduceTask` and now just needs some unit tests.

            Show
            reiss David Reiss added a comment - Implemented as a CoaddPsf. Seems to work well. Added to `ImageMapReduceTask` and now just needs some unit tests.
            Hide
            reiss David Reiss added a comment -

            We now construct (potentially) spatially-varying PSF via CoaddPsf, by default if the reduce operation is 'average' or 'sum'.
            Added unit tests for all test cases that construct exposures via 'average' or 'sum'.
            Rebased against latest master and tests pass.

            Show
            reiss David Reiss added a comment - We now construct (potentially) spatially-varying PSF via CoaddPsf, by default if the reduce operation is 'average' or 'sum'. Added unit tests for all test cases that construct exposures via 'average' or 'sum'. Rebased against latest master and tests pass.
            Hide
            reiss David Reiss added a comment -

            Ian, would you be able to review this ticket for me? A few minor changes scattered throughout, but the primary addition is in imageMapReduce (`ImageReducerSubtask._constructPsf()`), and corresponding unit test.

            Thanks!

            Show
            reiss David Reiss added a comment - Ian, would you be able to review this ticket for me? A few minor changes scattered throughout, but the primary addition is in imageMapReduce (`ImageReducerSubtask._constructPsf()`), and corresponding unit test. Thanks!
            Hide
            reiss David Reiss added a comment -
            Show
            reiss David Reiss added a comment - Jenkins build successful: https://ci.lsst.codes/job/stack-os-matrix/22641/
            Hide
            sullivan Ian Sullivan added a comment -

            Looks good, I had only a few comments. Since I initiated the pull request, it looks like I can't mark it as 'approved' on GitHub, so in the future please create a pull request before sending a ticket for review.

            Show
            sullivan Ian Sullivan added a comment - Looks good, I had only a few comments. Since I initiated the pull request, it looks like I can't mark it as 'approved' on GitHub, so in the future please create a pull request before sending a ticket for review.
            Hide
            reiss David Reiss added a comment -

            Passed CI (#22675), merging.

            Show
            reiss David Reiss added a comment - Passed CI (#22675), merging.

              People

              • Assignee:
                reiss David Reiss
                Reporter:
                reiss David Reiss
                Reviewers:
                Ian Sullivan
                Watchers:
                David Reiss, Ian Sullivan
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel