Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9671

Rename custom pybind11 namespace to python

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Story Points:
      0.5
    • Sprint:
      DRP S17-4
    • Team:
      Data Release Production

      Description

      Currently we use the pybind11 namespace for custom wrapping helper functions in header files.
      This namespace clashes with the upstream pybind11 one.
      Change it to python as required by the new rules.

        Attachments

          Activity

          Hide
          jbosch Jim Bosch added a comment -

          I believe we agreed not to put namespace py = pybind11; and using namespace pybind11::literals; in header files (as you've done here in the afw changes), unless they're at function scope. Otherwise looks good.

          Show
          jbosch Jim Bosch added a comment - I believe we agreed not to put namespace py = pybind11; and using namespace pybind11::literals; in header files (as you've done here in the afw changes), unless they're at function scope. Otherwise looks good.
          Hide
          pschella Pim Schellart [X] (Inactive) added a comment -

          I just moved them around, they were already there. But yes I agree.

          Show
          pschella Pim Schellart [X] (Inactive) added a comment - I just moved them around, they were already there. But yes I agree.
          Hide
          pschella Pim Schellart [X] (Inactive) added a comment -

          Merged with requested changes.

          Show
          pschella Pim Schellart [X] (Inactive) added a comment - Merged with requested changes.

            People

            Assignee:
            pschella Pim Schellart [X] (Inactive)
            Reporter:
            pschella Pim Schellart [X] (Inactive)
            Reviewers:
            Jim Bosch
            Watchers:
            Jim Bosch, Pim Schellart [X] (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins Builds

                No builds found.