Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-971

Task initialisation should validate the config

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_base
    • Labels:

      Description

      Config validation and freezing is currently carried out by the argument parser.

      This ticket requests that the config validation (also?) be carried out by the task constructors. This should be an essentially free operation, which may require caching the status in the Config object.

        Attachments

          Issue Links

          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-35817 Turn off compatibility mode for image differencing

          • Done
          is triggering

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-35949 revamp config+schema validation for measurement tasks

          • To Do
          relates to

          Bug - A problem which impairs or prevents the functions of the product. DM-25928 RawIngestTask can't take default config

          • To Do

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-972 Task initialisation should freeze the config

          • To Do

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-32964 SimplePipelineExecutor should validate and freeze the config

          • Done

            Activity

            Ascending order - Click to sort in descending order
            8 older comments
            Hide
            Permalink
            mfisherlevine Merlin Fisher-Levine added a comment -

            Fully agree, I was extremely unimpressed after several hours of debugging and feeling like I was going crazy to finally find that very unexpected code.

            Show
            mfisherlevine Merlin Fisher-Levine added a comment - Fully agree, I was extremely unimpressed after several hours of debugging and feeling like I was going crazy to finally find that very unexpected code.
            Hide
            Permalink
            Parejkoj John Parejko added a comment - - edited

            Jenkins with ci_hsc+ci_imsim: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/37204/pipeline

            Show
            Parejkoj John Parejko added a comment - - edited Jenkins with ci_hsc+ci_imsim: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/37204/pipeline
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Eli Rykoff: are you ok to review this? It's 10 PRs, but they're mostly a line or two (meas_base and pipe_tasks are a few dozen lines each). We've talked about it, so I figure it might be on your mind. Jenkins built cleanly with ci_hsc and ci_imsim.

            Show
            Parejkoj John Parejko added a comment - Eli Rykoff : are you ok to review this? It's 10 PRs, but they're mostly a line or two (meas_base and pipe_tasks are a few dozen lines each). We've talked about it, so I figure it might be on your mind. Jenkins built cleanly with ci_hsc and ci_imsim. https://github.com/lsst/pipe_base/pull/272 https://github.com/lsst/pipe_tasks/pull/711 https://github.com/lsst/meas_base/pull/221 https://github.com/lsst/verify/pull/101 https://github.com/lsst/ap_verify/pull/166 https://github.com/lsst/faro/pull/138 https://github.com/lsst/atmospec/pull/22 https://github.com/lsst/meas_modelfit/pull/101 https://github.com/lsst/meas_astrom/pull/168 https://github.com/lsst/meas_algorithms/pull/288
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Post review Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/37208/pipeline

            Show
            Parejkoj John Parejko added a comment - Post review Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/37208/pipeline
            Hide
            Permalink
            erykoff Eli Rykoff added a comment -

            There are some comments on the PR that I think are useful for DM-971, but I think that where we are now with this ticket is significantly improved from where we were before, even if we haven't removed all the foot-guns.

            Show
            erykoff Eli Rykoff added a comment - There are some comments on the PR that I think are useful for DM-971 , but I think that where we are now with this ticket is significantly improved from where we were before, even if we haven't removed all the foot-guns.

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              rhl Robert Lupton
              Reviewers:
              Eli Rykoff
              Watchers:
              Eli Rykoff, Jim Bosch, John Parejko, Krzysztof Findeisen, Merlin Fisher-Levine, Robert Lupton
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.