# Clean up meas_base pybind11 wrappers

XMLWordPrintable

#### Details

• Type: Improvement
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
• Story Points:
2
• Sprint:
• Team:

#### Description

Rebasing meas_base and other packages with meas.base.Algorithm subclasses for the DM-9249 changes.

This will require new/different pybind11 wrappers for changed C++ interfaces.

#### Activity

Hide
Jim Bosch added a comment -

What needs to be done:

• Look at what packages changed in DM-9249.
• Rebase the pybind11 branch for those packages on master.
• Make sure the new classes and changed APIs in meas_base 9249 are wrapped for Python.
• Do the same (this part should be trivial) in other packages that changed.
Show
Jim Bosch added a comment - What needs to be done: Look at what packages changed in DM-9249 . Rebase the pybind11 branch for those packages on master. Make sure the new classes and changed APIs in meas_base 9249 are wrapped for Python. Do the same (this part should be trivial) in other packages that changed.
Hide
Jim Bosch added a comment -

For review, I'm commenting on the PR, but I'm planning to make the changes myself as per Russell Owen's request unless I hear otherwise before I finish commenting.

Show
Jim Bosch added a comment - For review, I'm commenting on the PR, but I'm planning to make the changes myself as per Russell Owen 's request unless I hear otherwise before I finish commenting.
Hide
Jim Bosch added a comment -

I'm leaving this assigned to Russell even though I'll be finishing it up, as I expect by the time I'm done he'll still have done most of the work.

Show
Jim Bosch added a comment - I'm leaving this assigned to Russell even though I'll be finishing it up, as I expect by the time I'm done he'll still have done most of the work.
Hide
Jim Bosch added a comment -

Review completed and fixes made. Waiting on two more (py2 and py3) Jenkins runs to verify it doesn't break anything before merging and squashing on tickets/DM-8467.

Show
Jim Bosch added a comment - Review completed and fixes made. Waiting on two more (py2 and py3) Jenkins runs to verify it doesn't break anything before merging and squashing on tickets/ DM-8467 .
Hide
Jim Bosch added a comment -

Merged (actually rebased and squashed) to tickets/DM-8467.

Show
Jim Bosch added a comment - Merged (actually rebased and squashed) to tickets/ DM-8467 .

#### People

Assignee:
Russell Owen
Reporter:
Russell Owen
Watchers:
Jim Bosch, Pim Schellart [X] (Inactive), Russell Owen