Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9711

Clean up meas_base pybind11 wrappers

    XMLWordPrintable

    Details

    • Story Points:
      2
    • Epic Link:
    • Sprint:
      Alert Production S17 - 3
    • Team:
      Alert Production

      Description

      Rebasing meas_base and other packages with `meas.base.Algorithm` subclasses for the DM-9249 changes.

      This will require new/different pybind11 wrappers for changed C++ interfaces.

        Attachments

          Issue Links

          is triggered by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-9249 Modify FlagHandler C++ and flagDecorator.py to make flag identification robust

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            What needs to be done:

            • Look at what packages changed in DM-9249.
            • Rebase the pybind11 branch for those packages on master.
            • Make sure the new classes and changed APIs in meas_base 9249 are wrapped for Python.
            • Do the same (this part should be trivial) in other packages that changed.
            Show
            jbosch Jim Bosch added a comment - What needs to be done: Look at what packages changed in DM-9249 . Rebase the pybind11 branch for those packages on master. Make sure the new classes and changed APIs in meas_base 9249 are wrapped for Python. Do the same (this part should be trivial) in other packages that changed.
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            For review, I'm commenting on the PR, but I'm planning to make the changes myself as per Russell Owen's request unless I hear otherwise before I finish commenting.

            Show
            jbosch Jim Bosch added a comment - For review, I'm commenting on the PR, but I'm planning to make the changes myself as per Russell Owen 's request unless I hear otherwise before I finish commenting.
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            I'm leaving this assigned to Russell even though I'll be finishing it up, as I expect by the time I'm done he'll still have done most of the work.

            Show
            jbosch Jim Bosch added a comment - I'm leaving this assigned to Russell even though I'll be finishing it up, as I expect by the time I'm done he'll still have done most of the work.
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Review completed and fixes made. Waiting on two more (py2 and py3) Jenkins runs to verify it doesn't break anything before merging and squashing on tickets/DM-8467.

            Show
            jbosch Jim Bosch added a comment - Review completed and fixes made. Waiting on two more (py2 and py3) Jenkins runs to verify it doesn't break anything before merging and squashing on tickets/ DM-8467 .
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Merged (actually rebased and squashed) to tickets/DM-8467.

            Show
            jbosch Jim Bosch added a comment - Merged (actually rebased and squashed) to tickets/ DM-8467 .

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Watchers:
              Jim Bosch, Pim Schellart [X] (Inactive), Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.