Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9711

Clean up meas_base pybind11 wrappers

    XMLWordPrintable

Details

    • 2
    • Alert Production S17 - 3
    • Alert Production

    Description

      Rebasing meas_base and other packages with `meas.base.Algorithm` subclasses for the DM-9249 changes.

      This will require new/different pybind11 wrappers for changed C++ interfaces.

      Attachments

        Issue Links

          Activity

            No builds found.
            rowen Russell Owen created issue -
            rowen Russell Owen made changes -
            Field Original Value New Value
            Epic Link DM-9155 [ 29718 ]
            rowen Russell Owen made changes -
            Link This issue is triggered by DM-9249 [ DM-9249 ]
            jbosch Jim Bosch added a comment -

            What needs to be done:

            • Look at what packages changed in DM-9249.
            • Rebase the pybind11 branch for those packages on master.
            • Make sure the new classes and changed APIs in meas_base 9249 are wrapped for Python.
            • Do the same (this part should be trivial) in other packages that changed.
            jbosch Jim Bosch added a comment - What needs to be done: Look at what packages changed in DM-9249 . Rebase the pybind11 branch for those packages on master. Make sure the new classes and changed APIs in meas_base 9249 are wrapped for Python. Do the same (this part should be trivial) in other packages that changed.
            jbosch Jim Bosch added a comment -

            For review, I'm commenting on the PR, but I'm planning to make the changes myself as per rowen's request unless I hear otherwise before I finish commenting.

            jbosch Jim Bosch added a comment - For review, I'm commenting on the PR, but I'm planning to make the changes myself as per rowen 's request unless I hear otherwise before I finish commenting.
            jbosch Jim Bosch added a comment -

            I'm leaving this assigned to Russell even though I'll be finishing it up, as I expect by the time I'm done he'll still have done most of the work.

            jbosch Jim Bosch added a comment - I'm leaving this assigned to Russell even though I'll be finishing it up, as I expect by the time I'm done he'll still have done most of the work.
            jbosch Jim Bosch made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            jbosch Jim Bosch made changes -
            Epic Link DM-9155 [ 29718 ] DM-7717 [ 26925 ]
            jbosch Jim Bosch added a comment -

            Review completed and fixes made. Waiting on two more (py2 and py3) Jenkins runs to verify it doesn't break anything before merging and squashing on tickets/DM-8467.

            jbosch Jim Bosch added a comment - Review completed and fixes made. Waiting on two more (py2 and py3) Jenkins runs to verify it doesn't break anything before merging and squashing on tickets/ DM-8467 .
            jbosch Jim Bosch made changes -
            Status In Progress [ 3 ] Reviewed [ 10101 ]
            jbosch Jim Bosch added a comment -

            Merged (actually rebased and squashed) to tickets/DM-8467.

            jbosch Jim Bosch added a comment - Merged (actually rebased and squashed) to tickets/ DM-8467 .
            jbosch Jim Bosch made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]

            People

              rowen Russell Owen
              rowen Russell Owen
              Jim Bosch, Pim Schellart [X] (Inactive), Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.