Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9715

cppIndex should raise Python's built-in IndexError

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: utils
    • Labels:
      None
    • Templates:
    • Story Points:
      0.5
    • Epic Link:
    • Sprint:
      Alert Production S17 - 3
    • Team:
      Alert Production

      Description

      In order to synthesis __iter__ from __getitem__ Python apparently requires exactly IndexError to be thrown, so that's what we should throw in these functions.

      That will require rewriting the testPybind11.cc unit test in a way that has access to Python symbols (which should be done anyway).

      There will likely be workaround code in afw/table/python/catalog.h that can be cleaned up after this change (I'll just catch OutOfRangeError there and re-throw as IndexError).

        Attachments

          Activity

            People

            • Assignee:
              rowen Russell Owen
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Jim Bosch, Pim Schellart [X] (Inactive)
              Watchers:
              Jim Bosch, Krzysztof Findeisen, Pim Schellart [X] (Inactive), Russell Owen
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel