Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9729

TSViewer should be refactored to better handle future mission additions

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: To Do
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: Firefly
    • Labels:
    • Team:
      Science User Interface

      Description

      Initially the requirements for the LC viewer were collectively saying that we needed a flux column that would control the images, table and xy plot. The viewer has evolved in a Time Series viewer which allow the user in principle to upload any IPAC table to 'play' with and find the period of a time dependent variable. The images features depend on very specific constraint expected either from the table (and service who generated it) or the user input.

      Currently, and for first release, the code has strong coupling around the flux column, the column is driving the images, table, xy plot and periodogram making the common code LcManager.js difficult to change with specific mission settings without changing it, in particular for the image feature.

      The code should consider first a basic use case for TSV that should work always with 2 column, which is Time column and Value column, used to plot and find period, with a layout being table and xy plot.

      Image feature should be consider as more advanced case where another selector(s)/filter(s) might be used for specific mission. The images needs several specific columns that can be exposed to the user to control them.

      In case of WISE the value column can be anything, but the images rely on 3 different column and a band (DM-9589).

      The generic case should be also reviewed as part of that refactoring.

      I think we need to review the code and refactor it so it can change easily when we start to add in the future more missions with specific image constraints.

        Attachments

          Issue Links

            Activity

            Hide
            ejoliet Emmanuel Joliet added a comment -

            This was partially addressed in DM-9589.
            LSST case and generic case is pending.

            Show
            ejoliet Emmanuel Joliet added a comment - This was partially addressed in DM-9589 . LSST case and generic case is pending.
            Hide
            tjenness Tim Jenness added a comment -

            Gregory Dubois-Felsmann what do you want to do about this old ticket?

            Show
            tjenness Tim Jenness added a comment - Gregory Dubois-Felsmann what do you want to do about this old ticket?
            Hide
            gpdf Gregory Dubois-Felsmann added a comment - - edited

            It's still relevant, if Portal development at IPAC is restarted. Time series viewing was a specific request from the LSP/RSP review committee.

            It's also relevant in the design of one of the UI components for the SPHEREx data archive.

            We're going to think about this more on the IPAC side over the next 6 months, under https://jira.ipac.caltech.edu/browse/FIREFLY-815 (sorry, not world readable), though probably no development would begin on that time scale.

            Show
            gpdf Gregory Dubois-Felsmann added a comment - - edited It's still relevant, if Portal development at IPAC is restarted. Time series viewing was a specific request from the LSP/RSP review committee. It's also relevant in the design of one of the UI components for the SPHEREx data archive. We're going to think about this more on the IPAC side over the next 6 months, under https://jira.ipac.caltech.edu/browse/FIREFLY-815 (sorry, not world readable), though probably no development would begin on that time scale.

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              ejoliet Emmanuel Joliet
              Watchers:
              Emmanuel Joliet, Gregory Dubois-Felsmann, Leanne Guy, Loi Ly, Tim Jenness, Trey Roby
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:

                  Jenkins

                  No builds found.