Details
-
Type:
Improvement
-
Status: To Do
-
Resolution: Unresolved
-
Fix Version/s: None
-
Component/s: Firefly
-
Labels:
-
Team:Science User Interface
Description
Initially the requirements for the LC viewer were collectively saying that we needed a flux column that would control the images, table and xy plot. The viewer has evolved in a Time Series viewer which allow the user in principle to upload any IPAC table to 'play' with and find the period of a time dependent variable. The images features depend on very specific constraint expected either from the table (and service who generated it) or the user input.
Currently, and for first release, the code has strong coupling around the flux column, the column is driving the images, table, xy plot and periodogram making the common code LcManager.js difficult to change with specific mission settings without changing it, in particular for the image feature.
The code should consider first a basic use case for TSV that should work always with 2 column, which is Time column and Value column, used to plot and find period, with a layout being table and xy plot.
Image feature should be consider as more advanced case where another selector(s)/filter(s) might be used for specific mission. The images needs several specific columns that can be exposed to the user to control them.
In case of WISE the value column can be anything, but the images rely on 3 different column and a band (DM-9589).
The generic case should be also reviewed as part of that refactoring.
I think we need to review the code and refactor it so it can change easily when we start to add in the future more missions with specific image constraints.
This was partially addressed in
DM-9589.LSST case and generic case is pending.