Fix Version/s: None
Sprint:Alert Production S17 - 3, Alert Production S17 - 4
Created pull requests for matchPessimisticB ticket branches for
DM-9750 in meas_astrom and meas_algorithms.
The matcher currently works in both star starved, high galactic latitude fields and dense galactic plane fields where the previous MatchOptimisticBTask fails. This ticket puts in a slight change to the matcher API changing the maxMatchDist afwGeom.Angle to a pipeBase struct that contains tolerance and state variables communicate pervious results of the matchAndFit wcs loop into the matcher. This ticket also supersedes
DM-8163 as the loading of the reference catalog padded by the maximum shift distance of the matcher has been implemented here. https://github.com/lsst/meas_astrom/pull/62
In meas_algorithms matcherSourceSelector now excludes all saturated, edge, and interpolated objects. https://github.com/lsst/meas_algorithms/pull/71
Full response to git pull request (#62) comments added to ticket. Ticket branch has also been rebased to master.
This is a very nice improvement. I put some suggestions on github. Colin Slater when you are done reviewing this please mark it "reviewed"
Looks to me like everything has been addressed, commit history is fixed up nicely, if it passes Jenkins you're good to merge.
Finished review. Waiting on Jenkins build and final push to master.
Created new ticket branch to be begin work.