Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9750

Clean up and stackify matchPessimisticB code

    XMLWordPrintable

    Details

    • Story Points:
      10
    • Epic Link:
    • Sprint:
      Alert Production S17 - 3, Alert Production S17 - 4
    • Team:
      Alert Production

      Description

      This ticket is for cleaning up the prototype matcher constructed in DM-8110 and exercised and improved in DM-8113.

      The final product of this ticket is a cleaned up Python code for the new matchPessimisticB code to be fully stackified and merged onto master as a plug and playable option.

        Attachments

          Issue Links

          is child task of

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8110 Implement matcher prototype

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8113 Implement fixes required

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            cmorrison Chris Morrison [X] (Inactive) added a comment -

            Created new ticket branch to be begin work.

            Show
            cmorrison Chris Morrison [X] (Inactive) added a comment - Created new ticket branch to be begin work.
            Hide
            Permalink
            cmorrison Chris Morrison [X] (Inactive) added a comment -

            Created pull requests for matchPessimisticB ticket branches for DM-9750 in meas_astrom and meas_algorithms.

            The matcher currently works in both star starved, high galactic latitude fields and dense galactic plane fields where the previous MatchOptimisticBTask fails. This ticket puts in a slight change to the matcher API changing the maxMatchDist afwGeom.Angle to a pipeBase struct that contains tolerance and state variables communicate pervious results of the matchAndFit wcs loop into the matcher. This ticket also supersedes DM-8163 as the loading of the reference catalog padded by the maximum shift distance of the matcher has been implemented here. https://github.com/lsst/meas_astrom/pull/62

            In meas_algorithms matcherSourceSelector now excludes all saturated, edge, and interpolated objects. https://github.com/lsst/meas_algorithms/pull/71

            Show
            cmorrison Chris Morrison [X] (Inactive) added a comment - Created pull requests for matchPessimisticB ticket branches for DM-9750 in meas_astrom and meas_algorithms. The matcher currently works in both star starved, high galactic latitude fields and dense galactic plane fields where the previous MatchOptimisticBTask fails. This ticket puts in a slight change to the matcher API changing the maxMatchDist afwGeom.Angle to a pipeBase struct that contains tolerance and state variables communicate pervious results of the matchAndFit wcs loop into the matcher. This ticket also supersedes DM-8163 as the loading of the reference catalog padded by the maximum shift distance of the matcher has been implemented here. https://github.com/lsst/meas_astrom/pull/62 In meas_algorithms matcherSourceSelector now excludes all saturated, edge, and interpolated objects. https://github.com/lsst/meas_algorithms/pull/71
            Hide
            Permalink
            cmorrison Chris Morrison [X] (Inactive) added a comment -

            Full response to git pull request (#62) comments added to ticket. Ticket branch has also been rebased to master.

            Show
            cmorrison Chris Morrison [X] (Inactive) added a comment - Full response to git pull request (#62) comments added to ticket. Ticket branch has also been rebased to master.
            Hide
            Permalink
            rowen Russell Owen added a comment -

            This is a very nice improvement. I put some suggestions on github. Colin Slater when you are done reviewing this please mark it "reviewed"

            Show
            rowen Russell Owen added a comment - This is a very nice improvement. I put some suggestions on github. Colin Slater when you are done reviewing this please mark it "reviewed"
            Hide
            Permalink
            ctslater Colin Slater added a comment -

            Looks to me like everything has been addressed, commit history is fixed up nicely, if it passes Jenkins you're good to merge.

            Show
            ctslater Colin Slater added a comment - Looks to me like everything has been addressed, commit history is fixed up nicely, if it passes Jenkins you're good to merge.
            Hide
            Permalink
            cmorrison Chris Morrison [X] (Inactive) added a comment -

            Finished review. Waiting on Jenkins build and final push to master.

            Show
            cmorrison Chris Morrison [X] (Inactive) added a comment - Finished review. Waiting on Jenkins build and final push to master.

              People

              Assignee:
              cmorrison Chris Morrison [X] (Inactive)
              Reporter:
              cmorrison Chris Morrison [X] (Inactive)
              Reviewers:
              Colin Slater, Russell Owen
              Watchers:
              Chris Morrison [X] (Inactive), Colin Slater, Russell Owen, Simon Krughoff
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.