Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9752

Add jointcal to lsst_distrib

    XMLWordPrintable

    Details

      Description

      This ticket implements RFC-300.

      Once jointcal has been ported to pybind11 (DM-9187), it will be ready to join the stack in lsst_distrib. This includes the jointcal_cholmod dependency, and the optional testdata_jointcal package (which will be excluded from most installs due to size).

      Note to Joshua Hoblitt: We'll need to add testdata_jointcal to the various exclude files once this is ready to go. I'll ping you at that time.

        Attachments

          Issue Links

          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-9187 port jointcal to pybind11

          • Done
          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-300 Add jointcal to lsst_distrib

          • Implemented

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            I've added jointcal to lsst_distrib's table file as Required, and testdata_jointcal to the exclustion manifest.remap. Please look it over and let me know if anything else is needed.

            I did start a jenkins run: https://ci.lsst.codes/job/stack-os-matrix/22338/

            Show
            Parejkoj John Parejko added a comment - I've added jointcal to lsst_distrib's table file as Required , and testdata_jointcal to the exclustion manifest.remap . Please look it over and let me know if anything else is needed. I did start a jenkins run: https://ci.lsst.codes/job/stack-os-matrix/22338/
            Hide
            Permalink
            jhoblitt Joshua Hoblitt added a comment -

            These branches look fine but the lsstsw branch needs to be rebased before merge. It would be nice if PRs were open before asking for review.

            Show
            jhoblitt Joshua Hoblitt added a comment - These branches look fine but the lsstsw branch needs to be rebased before merge. It would be nice if PRs were open before asking for review.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Shoot: sorry about that! I usually make the PRs as soon as I've pushed, but I didn't think of it this time because the changes were so small.

            Always feel free to request that the PRs get made before you do the review.

            I've rebased lsstsw.

            Show
            Parejkoj John Parejko added a comment - Shoot: sorry about that! I usually make the PRs as soon as I've pushed, but I didn't think of it this time because the changes were so small. Always feel free to request that the PRs get made before you do the review. I've rebased lsstsw.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Thanks for the review: I waited for after the weekend to merge, incase it triggers issues.

            Show
            Parejkoj John Parejko added a comment - Thanks for the review: I waited for after the weekend to merge, incase it triggers issues.

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Joshua Hoblitt
              Watchers:
              John Parejko, Joshua Hoblitt, Simon Krughoff
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.