Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9758

astshim fails to build on linux

    XMLWordPrintable

    Details

      Description

      astshim fails to build on linux using Jenkins. Here is a build log
      https://ci.lsst.codes/job/stack-os-matrix/22127/label=centos-7,python=py2/console

      Also fix build warnings

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8439 Add wrapper on astshim to take point lists

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            rowen Russell Owen added a comment -

            There were two build issues (neither of which showed up on macOS clang):

            • KeyMap used std::vector<std::string const> instead of std::vector<std::string> in one place
            • A few methods of KeyMap should have been const

            I also changed the following:

            • Made FrameSet attributes BASE and CURRENT constexpr
            • Some C++ lines were too long
            • Modernized the pybind11 wrappers by using anonymous namespace and importing modules after declaring the module
              (in order to keep the two instances of the extension name together)

            I separated these into individual commits to make it easier to see what's going on.

            Show
            rowen Russell Owen added a comment - There were two build issues (neither of which showed up on macOS clang): KeyMap used std::vector<std::string const> instead of std::vector<std::string> in one place A few methods of KeyMap should have been const I also changed the following: Made FrameSet attributes BASE and CURRENT constexpr Some C++ lines were too long Modernized the pybind11 wrappers by using anonymous namespace and importing modules after declaring the module (in order to keep the two instances of the extension name together) I separated these into individual commits to make it easier to see what's going on.
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment -

            Looks good; some minor comments on GitHub.

            Show
            krzys Krzysztof Findeisen added a comment - Looks good; some minor comments on GitHub.

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Krzysztof Findeisen
              Watchers:
              Krzysztof Findeisen, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.