Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9758

astshim fails to build on linux

    XMLWordPrintable

Details

    • 2
    • Alert Production S17 - 3
    • Alert Production

    Description

      astshim fails to build on linux using Jenkins. Here is a build log
      https://ci.lsst.codes/job/stack-os-matrix/22127/label=centos-7,python=py2/console

      Also fix build warnings

      Attachments

        Issue Links

          Activity

            rowen Russell Owen added a comment -

            There were two build issues (neither of which showed up on macOS clang):

            • KeyMap used std::vector<std::string const> instead of std::vector<std::string> in one place
            • A few methods of KeyMap should have been const

            I also changed the following:

            • Made FrameSet attributes BASE and CURRENT constexpr
            • Some C++ lines were too long
            • Modernized the pybind11 wrappers by using anonymous namespace and importing modules after declaring the module
              (in order to keep the two instances of the extension name together)

            I separated these into individual commits to make it easier to see what's going on.

            rowen Russell Owen added a comment - There were two build issues (neither of which showed up on macOS clang): KeyMap used std::vector<std::string const> instead of std::vector<std::string> in one place A few methods of KeyMap should have been const I also changed the following: Made FrameSet attributes BASE and CURRENT constexpr Some C++ lines were too long Modernized the pybind11 wrappers by using anonymous namespace and importing modules after declaring the module (in order to keep the two instances of the extension name together) I separated these into individual commits to make it easier to see what's going on.

            Looks good; some minor comments on GitHub.

            krzys Krzysztof Findeisen added a comment - Looks good; some minor comments on GitHub.

            People

              rowen Russell Owen
              rowen Russell Owen
              Krzysztof Findeisen
              Krzysztof Findeisen, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.