1. GaussianCentroidAlgorithm: the reference to getFlagDefinitions() is a very handy piece of information, though perhaps it would be helpful to mention its location (PixelFlags.h). It seems this bit of code deserves a much higher profile in the documentation. I can refer to it in the Confluence docs, but is it referenced elsewhere in the task-level docs?
Actually, this was referring to the getFlagDefinitions() in GaussianCentroidAlgorithm, not the one in PixelFlags. Each algorithm implemented in C++ has its own flags, and PixelFlags just has a larger set because it's an algorithm that only sets flags (PixelFlags is a measurement algorithms that simply looks for which mask bits are set within the Footprint of a source).
This isn't mentioned in the Task docs yet, but that's still a work in progress (
2. PixelFlagsAlgorithm::Result: my parser gagged on this comment:
- ResultMapper for PixelFlagsAlgorithm, which only defines a flag set out its output.
Fixed (to "which includes only flag fields").
3. This may be off-topic for this review, but where would one find an explanation of the plug-in framework? This would be helpful reading for someone trying to understand the code and comments. (I assume it exists, but I don't know where.)
There's some in the Doxygen package overview page (mostly from the perspective of how to write new plugins). There'll be more coming in
DM-976 (and probably some future tickets).