Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9784

Implement test for overlapping galaxies

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_deblender
    • Labels:
      None

      Description

      Once DM-9644 is completed we need to create a test that calculates the amount of overlap between galaxies, basically

      (Si Sj)2 / ((∑Si2) (∑Sj2))

      for both the measured intensities and simulated intensities.

        Attachments

          Issue Links

            Activity

            No builds found.
            fred3m Fred Moolekamp created issue -
            fred3m Fred Moolekamp made changes -
            Field Original Value New Value
            Epic Link DM-8140 [ 27595 ]
            fred3m Fred Moolekamp made changes -
            Link This issue is blocked by DM-9644 [ DM-9644 ]
            fred3m Fred Moolekamp made changes -
            Story Points 4 3
            fred3m Fred Moolekamp made changes -
            Sprint DRP S17-5 [ 364 ]
            swinbank John Swinbank made changes -
            Description Once DM-9644 is completed we need to create a test that calculates the amount of overlap between galaxies, basically np.dot(S_i^out, S_j^out)^2 / (np.dot(S_i^out, S_i^out)np.dot(S_j^out, S_j^out)) - np.dot(S_i^in, S_j^in)^2 / (np.dot(S_i^in, S_i^in)np.dot(S_j^in, S_j^in)).

            Comparing this to the deblender results ensures that we are handling overlapping galaxies properly.
            Once DM-9644 is completed we need to create a test that calculates the amount of overlap between galaxies, basically {{np.dot(S_i^out, S_j^out)^2 / (np.dot(S_i^out, S_i^out)np.dot(S_j^out, S_j^out)) - np.dot(S_i^in, S_j^in)^2 / (np.dot(S_i^in, S_i^in)np.dot(S_j^in, S_j^in))}}.

            Comparing this to the deblender results ensures that we are handling overlapping galaxies properly.
            swinbank John Swinbank made changes -
            Link This issue is duplicated by DM-9956 [ DM-9956 ]
            fred3m Fred Moolekamp made changes -
            Sprint DRP S17-5 [ 364 ] DRP S17-6 [ 365 ]
            swinbank John Swinbank made changes -
            Sprint DRP S17-6 [ 365 ]
            swinbank John Swinbank made changes -
            Epic Link DM-8140 [ 27595 ] DM-10353 [ 32070 ]
            swinbank John Swinbank made changes -
            Sprint DRP F17-1 [ 614 ]
            fred3m Fred Moolekamp made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            fred3m Fred Moolekamp made changes -
            Link This issue relates to DM-10483 [ DM-10483 ]
            fred3m Fred Moolekamp made changes -
            Link This issue relates to DM-10502 [ DM-10502 ]
            fred3m Fred Moolekamp made changes -
            Sprint DRP F17-1 [ 614 ] DRP S17-6 [ 365 ]
            Hide
            fred3m Fred Moolekamp added a comment -

            Changed to the current sprint, since this is an important test for the new deblender.

            Show
            fred3m Fred Moolekamp added a comment - Changed to the current sprint, since this is an important test for the new deblender.
            fred3m Fred Moolekamp made changes -
            Epic Link DM-10353 [ 32070 ] DM-8140 [ 27595 ]
            Hide
            fred3m Fred Moolekamp added a comment -

            This ticket has also included work to improve the API for the meas_deblender.sim module, which compares the simulated true values to the deblended measurements.

            Show
            fred3m Fred Moolekamp added a comment - This ticket has also included work to improve the API for the meas_deblender.sim module, which compares the simulated true values to the deblended measurements.
            fred3m Fred Moolekamp made changes -
            Description Once DM-9644 is completed we need to create a test that calculates the amount of overlap between galaxies, basically {{np.dot(S_i^out, S_j^out)^2 / (np.dot(S_i^out, S_i^out)np.dot(S_j^out, S_j^out)) - np.dot(S_i^in, S_j^in)^2 / (np.dot(S_i^in, S_i^in)np.dot(S_j^in, S_j^in))}}.

            Comparing this to the deblender results ensures that we are handling overlapping galaxies properly.
            Once DM-9644 is completed we need to create a test that calculates the amount of overlap between galaxies, basically

            ( S~i~ )^2^



            Comparing this to the deblender results ensures that we are handling overlapping galaxies properly.
            fred3m Fred Moolekamp made changes -
            Description Once DM-9644 is completed we need to create a test that calculates the amount of overlap between galaxies, basically

            ( S~i~ )^2^



            Comparing this to the deblender results ensures that we are handling overlapping galaxies properly.
            Once DM-9644 is completed we need to create a test that calculates the amount of overlap between galaxies, basically

            (S{~}i~ S{~}j~)^2^ / ((∑S{~}i~)^2^ (∑S{~}j~)^2^)

            for both the measured intensities and simulated intensities.
            fred3m Fred Moolekamp made changes -
            Story Points 3 5
            Hide
            fred3m Fred Moolekamp added a comment -

            Hi Peter, do you mind reviewing this ticket?

            The main work can be seen in testSingleSim.ipynb.

            In addition to implementing the test for overlapping galaxies (see the code here), I also updated the code to make it easier to compare different versions of the deblender and the simulated data using all of the tests we have developed so far.

            Show
            fred3m Fred Moolekamp added a comment - Hi Peter, do you mind reviewing this ticket? The main work can be seen in testSingleSim.ipynb . In addition to implementing the test for overlapping galaxies (see the code here ), I also updated the code to make it easier to compare different versions of the deblender and the simulated data using all of the tests we have developed so far.
            fred3m Fred Moolekamp made changes -
            Reviewers Peter Melchior [ pmelchior ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            fred3m Fred Moolekamp made changes -
            Description Once DM-9644 is completed we need to create a test that calculates the amount of overlap between galaxies, basically

            (S{~}i~ S{~}j~)^2^ / ((∑S{~}i~)^2^ (∑S{~}j~)^2^)

            for both the measured intensities and simulated intensities.
            Once DM-9644 is completed we need to create a test that calculates the amount of overlap between galaxies, basically

            (S{~}i~ S{~}j~)^2^ / ((∑S{~}i~^2^) (∑S{~}j~^2^))

            for both the measured intensities and simulated intensities.
            Hide
            fred3m Fred Moolekamp added a comment -

            I fixed the equation in the description to match what is actually done.

            Show
            fred3m Fred Moolekamp added a comment - I fixed the equation in the description to match what is actually done.
            Hide
            pmelchior Peter Melchior added a comment -

            This nicely shows if the deblender works or does too little or too much.

            Show
            pmelchior Peter Melchior added a comment - This nicely shows if the deblender works or does too little or too much.
            pmelchior Peter Melchior made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            fred3m Fred Moolekamp made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]

              People

              Assignee:
              fred3m Fred Moolekamp
              Reporter:
              fred3m Fred Moolekamp
              Reviewers:
              Peter Melchior
              Watchers:
              Fred Moolekamp, Peter Melchior
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  CI Builds

                  No builds found.