Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9789

pipelines.lsst.io v13 needs some fixes

    Details

    • Story Points:
      1
    • Epic Link:
    • Sprint:
      DRP S17-4, DRP S17-5
    • Team:
      Data Release Production

      Description

      After perusing the latest version of pipelines.lsst.io, I made the following comments on the merge commit:

      • metrics/v13_0.rst line 9: Should we explain that we are not trying to compare to the "glide path" in LDM-240 anymore and that the targets are hence goals for much later rather than thresholds we are supposed to meet with this release?
      • releases/note_source/v13_0.rst line 659: There's no release note that says that daf_butlerUtils was moved to obs_base? And I think the title of this would be a bit better if it had "definitions" appended.
      • releases/note_source/v13_0.rst line 786: If there were no documentation improvements, this section should be omitted. But I think there were some, at least to pipelines.lsst.io itself...

        Attachments

          Issue Links

            Activity

            Hide
            swinbank John Swinbank added a comment -

            My thoughts:

            1. I agree that there should be some sort of explanation here. I can draft some text, but I'm not sure who should sign off on it.
            2. I can add that note.
            3. This sounds like a question for Jonathan Sick.
            Show
            swinbank John Swinbank added a comment - My thoughts: I agree that there should be some sort of explanation here. I can draft some text, but I'm not sure who should sign off on it. I can add that note. This sounds like a question for Jonathan Sick .
            Hide
            jsick Jonathan Sick added a comment -

            Oh yes. I think we can list installation documentation improvements. I'll take #3 on a separate ticket If others want to take the first two.

            Show
            jsick Jonathan Sick added a comment - Oh yes. I think we can list installation documentation improvements. I'll take #3 on a separate ticket If others want to take the first two.
            Hide
            swinbank John Swinbank added a comment -

            Ok; I'll take the first two points. Thanks Jonathan!

            Show
            swinbank John Swinbank added a comment - Ok; I'll take the first two points. Thanks Jonathan!
            Hide
            swinbank John Swinbank added a comment -

            Pushed a ticket branch which contains the LDM-240 “glide path” metrics for v13.

            Show
            swinbank John Swinbank added a comment - Pushed a ticket branch which contains the LDM-240 “glide path” metrics for v13.
            Hide
            swinbank John Swinbank added a comment -

            Hi Kian-Tat Lim, could you check this please?

            Per the above, your third point is being tackled on DM-9791 by Jonathan Sick. Your other two points are:

            Show
            swinbank John Swinbank added a comment - Hi Kian-Tat Lim , could you check this please? Per the above, your third point is being tackled on DM-9791 by Jonathan Sick . Your other two points are: addressed in this PR: https://github.com/lsst/pipelines_lsst_io/pull/41 which is rendered here: https://pipelines.lsst.io/v/DM-9789/index.html
            Hide
            ktl Kian-Tat Lim added a comment -

            The photometry numbers don't look that good, but that's what we've got. Astrometry looks good.

            The ellipticity targets don't match with what I see in 20160204 ldm-240-both.xlsx: 100.0e-5 and 10000e-7 (or 1e-3, 1e-3)

            Show
            ktl Kian-Tat Lim added a comment - The photometry numbers don't look that good, but that's what we've got. Astrometry looks good. The ellipticity targets don't match with what I see in 20160204 ldm-240-both.xlsx : 100.0e-5 and 10000e-7 (or 1e-3, 1e-3)
            Hide
            swinbank John Swinbank added a comment -

            Looks like you're right — I used the design spec rather than F16 target. Good catch. I'll fix & merge.

            Show
            swinbank John Swinbank added a comment - Looks like you're right — I used the design spec rather than F16 target. Good catch. I'll fix & merge.

              People

              • Assignee:
                swinbank John Swinbank
                Reporter:
                ktl Kian-Tat Lim
                Reviewers:
                Kian-Tat Lim
                Watchers:
                Frossie Economou, John Swinbank, Jonathan Sick, Kian-Tat Lim
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel