Details
-
Type:
Bug
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ci_hsc, meas_modelfit, obs_subaru
-
Labels:
-
Story Points:2
-
Epic Link:
-
Sprint:DRP S17-4
-
Team:Data Release Production
Description
When per-pixel variances are turned off, CModel likelihoods are computed without using the variance at all. This would not matter in a pure likelihood fit, but it means the prior and likelihood are not given the appropriate relative weights - and the relative weighting is not even consistent; it depends on the noise level of the image.
Since the typical effect of this is to make the prior much more informative, there is some danger that fixing this bug will cause other problems due to poorly-constrained fits. To avoid this, I'll add a configuration option to tune the relative weighting of the prior via a constant (which we could set to the typical variance level of the images to get behavior like what we have now without the inconsistency).
Love the plot!
Some trivial comments on the GitHub PRs.