Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-980

convert measurement algorithms in ip_diffim

    XMLWordPrintable

    Details

      Description

      ip_diffim includes a few measurement algorithms which need to be converted to the new framework.

        Attachments

          Issue Links

            Activity

            Hide
            pgee Perry Gee added a comment -

            Simon, would you have time to review this change? Or get someone at UW who cares about this package to look at it?

            The code is in /u/pgee/DM-980b

            include/lsst/ip/diffim/DipoleAlgorithms.h | 413 +++++++++++++------
            python/lsst/ip/diffim/_init_.py | 9 +-
            python/lsst/ip/diffim/diffimLib.i | 30 +-
            python/lsst/ip/diffim/dipole.i | 102 +++++
            python/lsst/ip/diffim/dipoleMeasurement.py | 72 ++--
            python/lsst/ip/diffim/imagePsfMatch.py | 11 +-
            src/DipoleAlgorithms.cc | 475 +++++++++++++++++++++
            src/dipoleAlgorithm.cc | 618 ----------------------------
            tests/dipole.py | 199 +++++----
            ups/ip_diffim.cfg | 2 +-
            ups/ip_diffim.table | 2 +-

            Show
            pgee Perry Gee added a comment - Simon, would you have time to review this change? Or get someone at UW who cares about this package to look at it? The code is in /u/pgee/ DM-980 b include/lsst/ip/diffim/DipoleAlgorithms.h | 413 +++++++++++++------ python/lsst/ip/diffim/_ init _.py | 9 +- python/lsst/ip/diffim/diffimLib.i | 30 +- python/lsst/ip/diffim/dipole.i | 102 +++++ python/lsst/ip/diffim/dipoleMeasurement.py | 72 ++-- python/lsst/ip/diffim/imagePsfMatch.py | 11 +- src/DipoleAlgorithms.cc | 475 +++++++++++++++++++++ src/dipoleAlgorithm.cc | 618 ---------------------------- tests/dipole.py | 199 +++++---- ups/ip_diffim.cfg | 2 +- ups/ip_diffim.table | 2 +-
            Hide
            pgee Perry Gee added a comment -

            Simon, have you found someone to do this review?

            Show
            pgee Perry Gee added a comment - Simon, have you found someone to do this review?
            Hide
            pgee Perry Gee added a comment -

            Simon, please note a new push:

            Author: pgee <pgee@pgeepc2.physics.ucdavis.edu>
            Date: Mon Jan 5 12:24:21 2015 -0800

            DM-980 Move ip_diffim to meas_base framework

            Please enter the commit message for your changes. Lines starting

            include/lsst/ip/diffim/DipoleAlgorithms.h | 435 +++++++++++++-------
            python/lsst/ip/diffim/_init_.py | 9 +-
            python/lsst/ip/diffim/diffimLib.i | 31 +-
            python/lsst/ip/diffim/dipole.i | 102 +++++
            python/lsst/ip/diffim/dipoleMeasurement.py | 72 ++--
            python/lsst/ip/diffim/imagePsfMatch.py | 11 +-
            src/DipoleAlgorithms.cc | 472 +++++++++++++++++++++
            src/dipoleAlgorithm.cc | 618 ----------------------------
            tests/dipole.py | 234 ++++++-----
            ups/ip_diffim.cfg | 2 +-
            ups/ip_diffim.table | 2 +-
            11 files changed, 1054 insertions, 934 deletions

            Show
            pgee Perry Gee added a comment - Simon, please note a new push: Author: pgee <pgee@pgeepc2.physics.ucdavis.edu> Date: Mon Jan 5 12:24:21 2015 -0800 DM-980 Move ip_diffim to meas_base framework Please enter the commit message for your changes. Lines starting include/lsst/ip/diffim/DipoleAlgorithms.h | 435 +++++++++++++------- python/lsst/ip/diffim/_ init _.py | 9 +- python/lsst/ip/diffim/diffimLib.i | 31 +- python/lsst/ip/diffim/dipole.i | 102 +++++ python/lsst/ip/diffim/dipoleMeasurement.py | 72 ++-- python/lsst/ip/diffim/imagePsfMatch.py | 11 +- src/DipoleAlgorithms.cc | 472 +++++++++++++++++++++ src/dipoleAlgorithm.cc | 618 ---------------------------- tests/dipole.py | 234 ++++++----- ups/ip_diffim.cfg | 2 +- ups/ip_diffim.table | 2 +- 11 files changed, 1054 insertions , 934 deletions
            Hide
            pgee Perry Gee added a comment -

            After looking over the code, I believe that the dipole.py unittest is running OK, and that the WARNING being produced is an artifact. The tests appear to be passing. I will fix this problem once the review is done, but I think that dipole.py is operable.

            Show
            pgee Perry Gee added a comment - After looking over the code, I believe that the dipole.py unittest is running OK, and that the WARNING being produced is an artifact. The tests appear to be passing. I will fix this problem once the review is done, but I think that dipole.py is operable.
            Hide
            pgee Perry Gee added a comment -

            Simon, will you be able to finish this review by Thursday? I would like to get it in this cycle.

            Show
            pgee Perry Gee added a comment - Simon, will you be able to finish this review by Thursday? I would like to get it in this cycle.
            Hide
            krughoff Simon Krughoff added a comment -

            As long as the test passes, I'm happy.

            For the record, most of my comments are about consistency of namespaces and other minor things. I found nothing major. Feel free to merge. This code is scheduled for some work in the next cycle, so it's not terrible to leave things as they are.

            Show
            krughoff Simon Krughoff added a comment - As long as the test passes, I'm happy. For the record, most of my comments are about consistency of namespaces and other minor things. I found nothing major. Feel free to merge. This code is scheduled for some work in the next cycle, so it's not terrible to leave things as they are.

              People

              Assignee:
              pgee Perry Gee
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Simon Krughoff
              Watchers:
              Jim Bosch, Perry Gee, Simon Krughoff
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: