Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-981

convert measurement algorithms in meas_extensions_shapeHSM

    Details

      Description

      This is a low-priority ticket to replace the old-style plugins in meas_extensions_shapeHSM with new ones compatible with meas_base. As this isn't a part of the main-line stack, we should delay it until other the meas_base conversion is nearly (or perhaps fully) complete.

        Attachments

          Issue Links

            Activity

            Hide
            jbosch Jim Bosch added a comment -

            I have not yet moved the changes from HSC for this package. Please do Kron first.

            Show
            jbosch Jim Bosch added a comment - I have not yet moved the changes from HSC for this package. Please do Kron first.
            Hide
            pgee Perry Gee added a comment -

            I have completed the conversion of the previous version. I don't think the HSC one will require much more work, unless the config and outputs have been changed substantially. Please let me know when the HSC side is merged.

            Show
            pgee Perry Gee added a comment - I have completed the conversion of the previous version. I don't think the HSC one will require much more work, unless the config and outputs have been changed substantially. Please let me know when the HSC side is merged.
            Hide
            jbosch Jim Bosch added a comment -

            I have just finished DM-1920, which brings over the HSC changes, which were very extensive. However, it needs to build against a new version of the GalSim package, which is only available at present on lsst-dev, as version 1.2.lsst1. I'll keep working on getting a version of that out that can be installed via eups distrib, but it's now possible to work on lsst-dev in the meantime.

            This issue absolutely needs to be rebased on top of master before doing any more work, because DM-1920 changes essentially everything underneath it. It may actually be easier to start over again, but it's probably worth seeing how bad the rebase is first.

            Show
            jbosch Jim Bosch added a comment - I have just finished DM-1920 , which brings over the HSC changes, which were very extensive. However, it needs to build against a new version of the GalSim package, which is only available at present on lsst-dev, as version 1.2.lsst1. I'll keep working on getting a version of that out that can be installed via eups distrib, but it's now possible to work on lsst-dev in the meantime. This issue absolutely needs to be rebased on top of master before doing any more work, because DM-1920 changes essentially everything underneath it. It may actually be easier to start over again, but it's probably worth seeing how bad the rebase is first.
            Hide
            pgee Perry Gee added a comment -

            OK, hsmShape is ready for review. It may be a little ragged, since I am pushing this against the Sprint deadline. But I think that everything is working.

            I may clean up and push again tomorrow, if you don't get to this early.

            Show
            pgee Perry Gee added a comment - OK, hsmShape is ready for review. It may be a little ragged, since I am pushing this against the Sprint deadline. But I think that everything is working. I may clean up and push again tomorrow, if you don't get to this early.
            Hide
            pgee Perry Gee added a comment -

            Oh, sorry. Here is the diff.

            include/lsst/meas/extensions/shapeHSM/HsmMomentsControl.h | 124 ++++++++++++++++++++++++++++++++++++++++++++--------
            include/lsst/meas/extensions/shapeHSM/HsmShapeControl.h | 155 +++++++++++++++++++++++++++++++++++++++++++++++++++-------------
            python/lsst/meas/extensions/shapeHSM/_init_.py | 20 ++++++---
            python/lsst/meas/extensions/shapeHSM/hsmLib.i | 14 +++++-
            src/HsmMoments.cc | 144 +++++++++++-------------------------------------------------
            src/HsmShape.cc | 182 ++++++++++++++++++++++------------------------------------------------------
            tests/testHsm.py | 137 ++++++++++++++++++++++++++++++++-------------------------
            ups/meas_extensions_shapeHSM.cfg | 2 +-
            ups/meas_extensions_shapeHSM.table | 1 +

            Show
            pgee Perry Gee added a comment - Oh, sorry. Here is the diff. include/lsst/meas/extensions/shapeHSM/HsmMomentsControl.h | 124 ++++++++++++++++++++++++++++++++++++++++++++-------- include/lsst/meas/extensions/shapeHSM/HsmShapeControl.h | 155 +++++++++++++++++++++++++++++++++++++++++++++++++++------------- python/lsst/meas/extensions/shapeHSM/_ init _.py | 20 ++++++--- python/lsst/meas/extensions/shapeHSM/hsmLib.i | 14 +++++- src/HsmMoments.cc | 144 +++++++++++------------------------------------------------- src/HsmShape.cc | 182 ++++++++++++++++++++++------------------------------------------------------ tests/testHsm.py | 137 ++++++++++++++++++++++++++++++++------------------------- ups/meas_extensions_shapeHSM.cfg | 2 +- ups/meas_extensions_shapeHSM.table | 1 +
            Hide
            pgee Perry Gee added a comment -

            Just added whitespace and copyright cleanup on a separate commit

            Show
            pgee Perry Gee added a comment - Just added whitespace and copyright cleanup on a separate commit
            Hide
            pgee Perry Gee added a comment -

            two additional cleanups of the same type, and and accidental line deletion in previous commit of testHsm.py.

            Show
            pgee Perry Gee added a comment - two additional cleanups of the same type, and and accidental line deletion in previous commit of testHsm.py.
            Hide
            jbosch Jim Bosch added a comment -

            Review complete. No major concerns, but lots of little cleanup comments on the PR.

            Show
            jbosch Jim Bosch added a comment - Review complete. No major concerns, but lots of little cleanup comments on the PR.

              People

              • Assignee:
                pgee Perry Gee
                Reporter:
                jbosch Jim Bosch
                Reviewers:
                Jim Bosch
                Watchers:
                Jim Bosch, Perry Gee
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: