Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9810

Make PSFEx oversampling configurable

    XMLWordPrintable

Details

    • 1
    • Data Release Production

    Description

      Add a configuration option that lets PSFEx decide when to oversample PSF images.

      Attachments

        Issue Links

          Activity

            The psfex option is BASIS_TYPE which we want to allow to be PIXEL or PIXEL_AUTO.

            rearmstr Bob Armstrong added a comment - The psfex option is BASIS_TYPE which we want to allow to be PIXEL or PIXEL_AUTO.

            Thanks for reviewing Paul.

            rearmstr Bob Armstrong added a comment - Thanks for reviewing Paul.
            price Paul Price added a comment -

            Is it intentional that the new option has no default? Without a default, it needs a coordinated change in obs_subaru (and any other obs package that uses psfex) to set a value.

            I would have expected that it would have been a boolean option (e.g., allowOversampling) that then gets interpreted when setting the BASIS_TYPE parameter, but maybe what you've done makes more sense for those familiar with psfex.

            Is the FWHM = 3 pixels divide hardcoded in psfex?

            price Paul Price added a comment - Is it intentional that the new option has no default ? Without a default, it needs a coordinated change in obs_subaru (and any other obs package that uses psfex) to set a value. I would have expected that it would have been a boolean option (e.g., allowOversampling ) that then gets interpreted when setting the BASIS_TYPE parameter, but maybe what you've done makes more sense for those familiar with psfex. Is the FWHM = 3 pixels divide hardcoded in psfex?

            Ah, no. It should have a default. Thanks for catching that.

            I don't really want people to use the non-default option as the oversampling should be controlled from the other config parameters, unless they know what they are doing. We do want to use this option for hsc so we need to update obs_subaru. Should it be on the same ticket?

            Yes, the FWHM=3 is hardcoded into psfex.

            rearmstr Bob Armstrong added a comment - Ah, no. It should have a default. Thanks for catching that. I don't really want people to use the non-default option as the oversampling should be controlled from the other config parameters, unless they know what they are doing. We do want to use this option for hsc so we need to update obs_subaru. Should it be on the same ticket? Yes, the FWHM=3 is hardcoded into psfex.
            price Paul Price added a comment -

            Please update obs_subaru here. Otherwise we have to make another ticket, which is more work.

            price Paul Price added a comment - Please update obs_subaru here. Otherwise we have to make another ticket, which is more work.

            I've pushed obs_subaru changes. Please take a look.

            rearmstr Bob Armstrong added a comment - I've pushed obs_subaru changes. Please take a look.
            price Paul Price added a comment -

            Looks good.

            price Paul Price added a comment - Looks good.

            People

              rearmstr Bob Armstrong
              jbosch Jim Bosch
              Paul Price
              Bob Armstrong, Jim Bosch, Paul Price
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.