Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9811

Add 1.3 arcsec target seeing for convolved flux measurement

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_subaru
    • Labels:
    • Story Points:
      1
    • Epic Link:
    • Sprint:
      DRP S17-4
    • Team:
      Data Release Production

      Description

      Masayuki Tanaka asks that we also include a 1.3 arcsec target seeing in the ConvolvedFluxPlugin. This target seeing is larger than any expected seeing in the coadd, and so we'll always get a useful result.

        Attachments

          Activity

          Hide
          price Paul Price added a comment -

          Jenkins is running...

          price@pap-laptop:~/LSST/obs_subaru/config (tickets/DM-9811=) $ git sub-patch
          commit 36d3db02ea0306770955bfb15e575e13ff86fdab
          Author: Paul Price <price@astro.princeton.edu>
          Date:   Wed Mar 15 12:09:00 2017 +0900
           
              config: add 1.3 arcsec target seeing for convolved fluxes
              
              Requested by Masayuki Tanaka. This target seeing is larger than any
              expected seeing in the coadd, and so we'll always get a useful result.
           
          diff --git a/config/convolvedFluxes.py b/config/convolvedFluxes.py
          index fa9d0fc..9008825 100644
          --- a/config/convolvedFluxes.py
          +++ b/config/convolvedFluxes.py
          @@ -6,4 +6,4 @@ except ImportError as exc:
               print("Cannot import lsst.meas.extensions.convolved (%s): disabling convolved flux measurements" % (exc,))
           else:
               config.plugins.names.add("ext_convolved_ConvolvedFlux")
          -    # Default values for 'seeing' and 'aperture.radii' are suitable for HSC.
          +    config.plugins["ext_convolved_ConvolvedFlux"].seeing.append(8.0)
          

          Show
          price Paul Price added a comment - Jenkins is running... price@pap-laptop:~/LSST/obs_subaru/config (tickets/DM-9811=) $ git sub-patch commit 36d3db02ea0306770955bfb15e575e13ff86fdab Author: Paul Price <price@astro.princeton.edu> Date: Wed Mar 15 12:09:00 2017 +0900   config: add 1.3 arcsec target seeing for convolved fluxes Requested by Masayuki Tanaka. This target seeing is larger than any expected seeing in the coadd, and so we'll always get a useful result.   diff --git a/config/convolvedFluxes.py b/config/convolvedFluxes.py index fa9d0fc..9008825 100644 --- a/config/convolvedFluxes.py +++ b/config/convolvedFluxes.py @@ -6,4 +6,4 @@ except ImportError as exc: print("Cannot import lsst.meas.extensions.convolved (%s): disabling convolved flux measurements" % (exc,)) else: config.plugins.names.add("ext_convolved_ConvolvedFlux") - # Default values for 'seeing' and 'aperture.radii' are suitable for HSC. + config.plugins["ext_convolved_ConvolvedFlux"].seeing.append(8.0)
          Hide
          price Paul Price added a comment -

          Jenkins passed.

          Jim Bosch, would you please review this?

          Show
          price Paul Price added a comment - Jenkins passed . Jim Bosch , would you please review this?
          Hide
          jbosch Jim Bosch added a comment -

          Looks good!

          Show
          jbosch Jim Bosch added a comment - Looks good!
          Hide
          price Paul Price added a comment -

          Merged to master.

          Getting this onto HSC master in a nice way (preserving both the work commit and the merge commit) was a little complicated:

          price@pap-laptop:~/hsc/obs_subaru (master=) $ git rebase -p --onto origin/master 39bbfe0 lsst/master
          Successfully rebased and updated detached HEAD.
          price@pap-laptop:~/hsc/obs_subaru ((cd9e2ab7...)) $ git co master
          Warning: you are leaving 2 commits behind, not connected to
          any of your branches:
           
            cd9e2ab7 Merge branch 'tickets/DM-9811'
            9dd28270 config: add 1.3 arcsec target seeing for convolved fluxes
           
          If you want to keep them by creating a new branch, this may be a good time
          to do so with:
           
           git branch <new-branch-name> cd9e2ab7
           
          Switched to branch 'master'
          Your branch is up-to-date with 'origin/master'.
          price@pap-laptop:~/hsc/obs_subaru (master=) $ git merge cd9e2ab7
          Updating cb10fb0a..cd9e2ab7
          Fast-forward
           config/convolvedFluxes.py | 2 +-
           1 file changed, 1 insertion(+), 1 deletion(-)
          price@pap-laptop:~/hsc/obs_subaru (master>) $ git out
          commit cd9e2ab738a39067cf1173449e576681b3a64b07
          Merge: cb10fb0a 9dd28270
          Author: Paul Price <price@astro.princeton.edu>
          Date:   Wed Mar 15 15:12:03 2017 +0900
           
              Merge branch 'tickets/DM-9811'
           
          commit 9dd2827013e5e64532a3c317945eb70ec95cd0cd
          Author: Paul Price <price@astro.princeton.edu>
          Date:   Wed Mar 15 12:09:00 2017 +0900
           
              config: add 1.3 arcsec target seeing for convolved fluxes
              
              Requested by Masayuki Tanaka. This target seeing is larger than any
              expected seeing in the coadd, and so we'll always get a useful result.
          

          Show
          price Paul Price added a comment - Merged to master. Getting this onto HSC master in a nice way (preserving both the work commit and the merge commit) was a little complicated: price@pap-laptop:~/hsc/obs_subaru (master=) $ git rebase -p --onto origin/master 39bbfe0 lsst/master Successfully rebased and updated detached HEAD. price@pap-laptop:~/hsc/obs_subaru ((cd9e2ab7...)) $ git co master Warning: you are leaving 2 commits behind, not connected to any of your branches:   cd9e2ab7 Merge branch 'tickets/DM-9811' 9dd28270 config: add 1.3 arcsec target seeing for convolved fluxes   If you want to keep them by creating a new branch, this may be a good time to do so with:   git branch <new-branch-name> cd9e2ab7   Switched to branch 'master' Your branch is up-to-date with 'origin/master'. price@pap-laptop:~/hsc/obs_subaru (master=) $ git merge cd9e2ab7 Updating cb10fb0a..cd9e2ab7 Fast-forward config/convolvedFluxes.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) price@pap-laptop:~/hsc/obs_subaru (master>) $ git out commit cd9e2ab738a39067cf1173449e576681b3a64b07 Merge: cb10fb0a 9dd28270 Author: Paul Price <price@astro.princeton.edu> Date: Wed Mar 15 15:12:03 2017 +0900   Merge branch 'tickets/DM-9811'   commit 9dd2827013e5e64532a3c317945eb70ec95cd0cd Author: Paul Price <price@astro.princeton.edu> Date: Wed Mar 15 12:09:00 2017 +0900   config: add 1.3 arcsec target seeing for convolved fluxes Requested by Masayuki Tanaka. This target seeing is larger than any expected seeing in the coadd, and so we'll always get a useful result.

            People

            Assignee:
            price Paul Price
            Reporter:
            price Paul Price
            Reviewers:
            Jim Bosch
            Watchers:
            Jim Bosch, Paul Price
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.