Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: meas_extensions_shapeHSM
-
Labels:
-
Story Points:3
-
Epic Link:
-
Sprint:Science Pipelines DM-W15-4, Science Pipelines DM-W15-5
-
Team:Data Release Production
Description
This is a low-priority ticket to replace the old-style plugins in meas_extensions_shapeHSM with new ones compatible with meas_base. As this isn't a part of the main-line stack, we should delay it until other the meas_base conversion is nearly (or perhaps fully) complete.
Attachments
Issue Links
Activity
I have completed the conversion of the previous version. I don't think the HSC one will require much more work, unless the config and outputs have been changed substantially. Please let me know when the HSC side is merged.
Perry Gee
added a comment - I have completed the conversion of the previous version. I don't think the HSC one will require much more work, unless the config and outputs have been changed substantially. Please let me know when the HSC side is merged. I have just finished DM-1920, which brings over the HSC changes, which were very extensive. However, it needs to build against a new version of the GalSim package, which is only available at present on lsst-dev, as version 1.2.lsst1. I'll keep working on getting a version of that out that can be installed via eups distrib, but it's now possible to work on lsst-dev in the meantime.
This issue absolutely needs to be rebased on top of master before doing any more work, because DM-1920 changes essentially everything underneath it. It may actually be easier to start over again, but it's probably worth seeing how bad the rebase is first.
OK, hsmShape is ready for review. It may be a little ragged, since I am pushing this against the Sprint deadline. But I think that everything is working.
I may clean up and push again tomorrow, if you don't get to this early.
Perry Gee
added a comment - OK, hsmShape is ready for review. It may be a little ragged, since I am pushing this against the Sprint deadline. But I think that everything is working.
I may clean up and push again tomorrow, if you don't get to this early. Oh, sorry. Here is the diff.
include/lsst/meas/extensions/shapeHSM/HsmMomentsControl.h | 124 ++++++++++++++++++++++++++++++++++++++++++++--------
include/lsst/meas/extensions/shapeHSM/HsmShapeControl.h | 155 +++++++++++++++++++++++++++++++++++++++++++++++++++-------------
python/lsst/meas/extensions/shapeHSM/_init_.py | 20 ++++++---
python/lsst/meas/extensions/shapeHSM/hsmLib.i | 14 +++++-
src/HsmMoments.cc | 144 +++++++++++-------------------------------------------------
src/HsmShape.cc | 182 ++++++++++++++++++++++------------------------------------------------------
tests/testHsm.py | 137 ++++++++++++++++++++++++++++++++-------------------------
ups/meas_extensions_shapeHSM.cfg | 2 +-
ups/meas_extensions_shapeHSM.table | 1 +
Perry Gee
added a comment - Oh, sorry. Here is the diff.
include/lsst/meas/extensions/shapeHSM/HsmMomentsControl.h | 124 ++++++++++++++++++++++++++++++++++++++++++++--------
include/lsst/meas/extensions/shapeHSM/HsmShapeControl.h | 155 +++++++++++++++++++++++++++++++++++++++++++++++++++-------------
python/lsst/meas/extensions/shapeHSM/_ init _.py | 20 ++++++---
python/lsst/meas/extensions/shapeHSM/hsmLib.i | 14 +++++-
src/HsmMoments.cc | 144 +++++++++++-------------------------------------------------
src/HsmShape.cc | 182 ++++++++++++++++++++++------------------------------------------------------
tests/testHsm.py | 137 ++++++++++++++++++++++++++++++++-------------------------
ups/meas_extensions_shapeHSM.cfg | 2 +-
ups/meas_extensions_shapeHSM.table | 1 + Just added whitespace and copyright cleanup on a separate commit
Perry Gee
added a comment - Just added whitespace and copyright cleanup on a separate commit two additional cleanups of the same type, and and accidental line deletion in previous commit of testHsm.py.
Perry Gee
added a comment - two additional cleanups of the same type, and and accidental line deletion in previous commit of testHsm.py. 
I have not yet moved the changes from HSC for this package. Please do Kron first.