Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-981

convert measurement algorithms in meas_extensions_shapeHSM

    XMLWordPrintable

    Details

      Description

      This is a low-priority ticket to replace the old-style plugins in meas_extensions_shapeHSM with new ones compatible with meas_base. As this isn't a part of the main-line stack, we should delay it until other the meas_base conversion is nearly (or perhaps fully) complete.

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-1920 update shapeHSM wrappers to latest external version

          • Done
          has to be done before

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-2131 Resolve compiler warnings in new measurement framework

          • Done

            Activity

            Ascending order - Click to sort in descending order
            jbosch Jim Bosch created issue -
            jbosch Jim Bosch made changes -
            Field Original Value New Value
            Epic Link DM-16 [ 11264 ]
            jbosch Jim Bosch made changes -
            Rank Ranked higher
            jbosch Jim Bosch made changes -
            Description This is a low-priority ticket to replace the old-style plugins in meas_algorithms with new ones compatible with meas_base. As this isn't a part of the main-line stack, we should delay it until other the meas_base conversion is nearly (or perhaps fully) complete. This is a low-priority ticket to replace the old-style plugins in meas_extensions_shapeHSM with new ones compatible with meas_base. As this isn't a part of the main-line stack, we should delay it until other the meas_base conversion is nearly (or perhaps fully) complete.
            jbosch Jim Bosch made changes -
            Priority Major [ 3 ] Minor [ 4 ]
            jbosch Jim Bosch made changes -
            Rank Ranked lower
            jbosch Jim Bosch made changes -
            Rank Ranked higher
            jbosch Jim Bosch made changes -
            Rank Ranked higher
            jbosch Jim Bosch made changes -
            Epic Link DM-16 [ 11264 ] DM-1100 [ 13907 ]
            jbosch Jim Bosch made changes -
            Labels Measurement AppsPlanning
            jbosch Jim Bosch made changes -
            Story Points 2 3
            jbosch Jim Bosch made changes -
            Story Points 3 5
            jbosch Jim Bosch made changes -
            Labels AppsPlanning SciencePipelines
            jbosch Jim Bosch made changes -
            Sprint Science Pipelines DM-W15-4 [ 120 ]
            jbosch Jim Bosch made changes -
            Rank Ranked higher
            jbosch Jim Bosch made changes -
            Story Points 5 3
            pgee Perry Gee made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            jbosch Jim Bosch made changes -
            Link This issue blocks DM-1920 [ DM-1920 ]
            swinbank John Swinbank made changes -
            Sprint Science Pipelines DM-W15-4 [ 120 ] Science Pipelines DM-W15-4, Science Pipelines DM-W15-5 [ 120, 129 ]
            swinbank John Swinbank made changes -
            Rank Ranked higher
            swinbank John Swinbank made changes -
            Link This issue has to be done before DM-2131 [ DM-2131 ]
            pgee Perry Gee made changes -
            Reviewers Jim Bosch [ jbosch ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            pgee Perry Gee made changes -
            Status In Review [ 10004 ] In Progress [ 3 ]
            jbosch Jim Bosch made changes -
            Comment [ moved this work onto a new branch, tickets/DM-982. u/pgee/DM-982 was abandoned, but all the versions of KronFluxAlgorithm.h and KronFluxAlgorithm.cc were moved to the new branch, so the review of that code should still apply. Since the changes were so substantial, merging the u/pgee/DM-982 with master was not feasible.

             include/lsst/meas/extensions/photometryKron.h | 76 --
             .../extensions/photometryKron/KronFluxAlgorithm.h | 143 ++++
             .../meas/extensions/photometryKron/__init__.py | 3 +-
             .../lsst/meas/extensions/photometryKron/kronLib.i | 34 +-
             src/KronFluxAlgorithm.cc | 618 ++++++++++++++++
             src/KronPhotometry.cc | 759 --------------------
             tests/Kron.py | 163 +++--
             ups/meas_extensions_photometryKron.cfg | 2 +-
             ups/meas_extensions_photometryKron.table | 1 +
             9 files changed, 883 insertions(+), 916 deletions(-)

            Please note that KronFluxAlgorithm.h and
             KronFluxAlgorithm.cc are actually moved versions of KronPhotometry.h and KronShape.cc. I am now rather sorry I renamed them, since the git diff doesn't seem to know. If you have a fix for this, let me know ]
            pgee Perry Gee made changes -
            Status In Progress [ 3 ] In Review [ 10004 ]
            jbosch Jim Bosch made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            pgee Perry Gee made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            frossie Frossie Economou made changes -
            Team Measurement Framework [ 10205 ] Data Release Production [ 10301 ]

              People

              Assignee:
              pgee Perry Gee
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Jim Bosch
              Watchers:
              Jim Bosch, Perry Gee
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.