Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9833

Create new sourceSelector BaseClass

    XMLWordPrintable

    Details

    • Story Points:
      4
    • Sprint:
      Alert Production S17 - 4, Alert Production S17 - 5, Alert Production S17 - 6
    • Team:
      Alert Production

      Description

      Create new sourceSelector BaseClass as described in RFC-198.

        Attachments

          Issue Links

            Activity

            Hide
            Parejkoj John Parejko added a comment -

            To close out this ticket, flaggedSourceSelector needs to gain a unittest and be updated to match the new API (as our test case), and meas_algorithsm/measureAppCorr.py will need tweaks to work with flaggedSourceSelector.

            Show
            Parejkoj John Parejko added a comment - To close out this ticket, flaggedSourceSelector needs to gain a unittest and be updated to match the new API (as our test case), and meas_algorithsm/measureAppCorr.py will need tweaks to work with flaggedSourceSelector .
            Hide
            cmorrison Chris Morrison added a comment -

            Started writing new BaseSourceSelector class. New example class FlaggedSourceSelector and unittests will be written as part of this ticket.

            Show
            cmorrison Chris Morrison added a comment - Started writing new BaseSourceSelector class. New example class FlaggedSourceSelector and unittests will be written as part of this ticket.
            Hide
            cmorrison Chris Morrison added a comment -

            Completed initial attempt at new source selector abstract class meant to unify all the call signatures across all source selectors.

            Added new flaggedSourceSelector class to use the new API and have a proper unittest.

            Show
            cmorrison Chris Morrison added a comment - Completed initial attempt at new source selector abstract class meant to unify all the call signatures across all source selectors. Added new flaggedSourceSelector class to use the new API and have a proper unittest.
            Hide
            reiss David Reiss added a comment -

            I have reviewed this code. I'd like another pass after I see your responses to my comments, as I'm not sure I completely understood everything going on here.

            Show
            reiss David Reiss added a comment - I have reviewed this code. I'd like another pass after I see your responses to my comments, as I'm not sure I completely understood everything going on here.
            Hide
            reiss David Reiss added a comment -

            I found some issues with your updated code. Nothing major, but see comments in the PR.

            Show
            reiss David Reiss added a comment - I found some issues with your updated code. Nothing major, but see comments in the PR.
            Hide
            reiss David Reiss added a comment -

            OK, all looks good to me.

            Show
            reiss David Reiss added a comment - OK, all looks good to me.
            Hide
            cmorrison Chris Morrison added a comment -

            Cool thanks, just a reminder that this code is not going to get merged as is as there are a bunch of source selectors that need to be refactored as well. They will be merged into DM-9832.

            Show
            cmorrison Chris Morrison added a comment - Cool thanks, just a reminder that this code is not going to get merged as is as there are a bunch of source selectors that need to be refactored as well. They will be merged into DM-9832 .
            Hide
            cmorrison Chris Morrison added a comment -

            Finished code review and merged code from this ticket into tickets/DM-9832 branch that will hold all updates for this epic.

            Show
            cmorrison Chris Morrison added a comment - Finished code review and merged code from this ticket into tickets/ DM-9832 branch that will hold all updates for this epic.

              People

              Assignee:
              cmorrison Chris Morrison
              Reporter:
              cmorrison Chris Morrison
              Reviewers:
              David Reiss
              Watchers:
              Chris Morrison, David Reiss, John Parejko, Simon Krughoff
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: