Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9837

Refactor meas_astrom/catalogStarSelector to new BaseClass

    Details

      Attachments

        Issue Links

          Activity

          Hide
          Parejkoj John Parejko added a comment -

          Chris Morrison and I are doing it as part of pair coding to finish the epic.

          Show
          Parejkoj John Parejko added a comment - Chris Morrison and I are doing it as part of pair coding to finish the epic.
          Hide
          Parejkoj John Parejko added a comment -

          Jim Bosch: Do you mind reviewing this small change?

          The catalog selector isn't used anywhere in the stack that we could find, and it doesn't appear to have any tests, so we are not positive our changes work.

          Show
          Parejkoj John Parejko added a comment - Jim Bosch : Do you mind reviewing this small change? The catalog selector isn't used anywhere in the stack that we could find, and it doesn't appear to have any tests, so we are not positive our changes work.
          Hide
          jbosch Jim Bosch added a comment -

          Looks good. One very minor comment on the PR.

          Show
          jbosch Jim Bosch added a comment - Looks good. One very minor comment on the PR.
          Hide
          Parejkoj John Parejko added a comment -

          Thanks for the review.

          Merged and done.

          Show
          Parejkoj John Parejko added a comment - Thanks for the review. Merged and done.

            People

            • Assignee:
              cmorrison Chris Morrison
              Reporter:
              cmorrison Chris Morrison
              Reviewers:
              Jim Bosch
              Watchers:
              Chris Morrison, Jim Bosch, John Parejko
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel