Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9837

Refactor meas_astrom/catalogStarSelector to new BaseClass

    XMLWordPrintable

    Details

      Attachments

        Issue Links

        is blocked by

        Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-9833 Create new sourceSelector BaseClass

        • Done

        Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-9834 Create new starSelector BaseClass

        • Invalid
        relates to

        RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-560 Remove CatalogStarSelectorTask

        • Implemented

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          Parejkoj John Parejko added a comment -

          Chris Morrison [X] and I are doing it as part of pair coding to finish the epic.

          Show
          Parejkoj John Parejko added a comment - Chris Morrison [X] and I are doing it as part of pair coding to finish the epic.
          Hide
          Permalink
          Parejkoj John Parejko added a comment -

          Jim Bosch: Do you mind reviewing this small change?

          The catalog selector isn't used anywhere in the stack that we could find, and it doesn't appear to have any tests, so we are not positive our changes work.

          Show
          Parejkoj John Parejko added a comment - Jim Bosch : Do you mind reviewing this small change? The catalog selector isn't used anywhere in the stack that we could find, and it doesn't appear to have any tests, so we are not positive our changes work.
          Hide
          Permalink
          jbosch Jim Bosch added a comment -

          Looks good. One very minor comment on the PR.

          Show
          jbosch Jim Bosch added a comment - Looks good. One very minor comment on the PR.
          Hide
          Permalink
          Parejkoj John Parejko added a comment -

          Thanks for the review.

          Merged and done.

          Show
          Parejkoj John Parejko added a comment - Thanks for the review. Merged and done.

            People

            Assignee:
            cmorrison Chris Morrison [X] (Inactive)
            Reporter:
            cmorrison Chris Morrison [X] (Inactive)
            Reviewers:
            Jim Bosch
            Watchers:
            Chris Morrison [X] (Inactive), Jim Bosch, John Parejko
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.