Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-984

allow partial measurement results to be set when error flag is set

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_base
    • Labels:

      Description

      We need to be able to return values at the same time that an error
      flag is set.

      The easiest way to do this is to have Algorithms take a Result object
      as an output argument rather than return it. We'll revisit this design
      later.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-464 add and use "suspect" flag in slots and slot-like measurements

          • Won't Fix

            Activity

            Ascending order - Click to sort in descending order
            4 older comments
            Hide
            Permalink
            pgee Perry Gee added a comment -

            I think that everything is happy. I put in the changes you asked for, rebased, and did do the merge of your change to testPsfFlux.py and removed the centroid code in sfm.py.

            I am not able currently to get buildbot to run, but otherwise, everything is done.

            Show
            pgee Perry Gee added a comment - I think that everything is happy. I put in the changes you asked for, rebased, and did do the merge of your change to testPsfFlux.py and removed the centroid code in sfm.py. I am not able currently to get buildbot to run, but otherwise, everything is done.
            Hide
            Permalink
            pgee Perry Gee added a comment -

            I think I've done everything you asked on this ticket. I am still waiting for buildbot to be working.

            I did remove the extra Centroid code in sfm.py

            Show
            pgee Perry Gee added a comment - I think I've done everything you asked on this ticket. I am still waiting for buildbot to be working. I did remove the extra Centroid code in sfm.py
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            New Centroid code looks fine. Since the changes on this issue only affect one package, and we really don't expect them to break other packages at all, and buildbot is down anyway, let's just skip buildbot on this one. It's much more important to run it for DM-958. Feel free to merge.

            Show
            jbosch Jim Bosch added a comment - New Centroid code looks fine. Since the changes on this issue only affect one package, and we really don't expect them to break other packages at all, and buildbot is down anyway, let's just skip buildbot on this one. It's much more important to run it for DM-958 . Feel free to merge.
            Hide
            Permalink
            robyn Robyn Allsman [X] (Inactive) added a comment -

            OK, will do. I informed Robyn.

            Show
            robyn Robyn Allsman [X] (Inactive) added a comment - OK, will do. I informed Robyn.
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Heh, that was confusing. Once again, JIRA thinks that you are Robyn.

            Show
            jbosch Jim Bosch added a comment - Heh, that was confusing. Once again, JIRA thinks that you are Robyn.

              People

              Assignee:
              pgee Perry Gee
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Jim Bosch
              Watchers:
              Jim Bosch, Perry Gee, Robyn Allsman [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.