Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9840

Refactor meas_extenstions/psfexStarSelector to new BaseClass

    Details

      Attachments

        Issue Links

          Activity

          Hide
          Parejkoj John Parejko added a comment -

          Chris Morrison and I are doing this as a pair coding, to finish off the epic.

          Show
          Parejkoj John Parejko added a comment - Chris Morrison and I are doing this as a pair coding, to finish off the epic.
          Hide
          Parejkoj John Parejko added a comment -

          Simon Krughoff: you filed RFC-312 (make psfex the default), so I'm giving this to you to review.

          Note that it doesn't have any tests and doesn't appear to be used anywhere, so we can't guarantee that our changes work. The tests that do exist in meas_extensions_psfex use objectSize anyway, so this source selector may be entirely irrelevant. It's not documented, so we have no idea what it's trying to do.

          Show
          Parejkoj John Parejko added a comment - Simon Krughoff : you filed RFC-312 (make psfex the default), so I'm giving this to you to review. Note that it doesn't have any tests and doesn't appear to be used anywhere, so we can't guarantee that our changes work. The tests that do exist in meas_extensions_psfex use objectSize anyway, so this source selector may be entirely irrelevant. It's not documented, so we have no idea what it's trying to do.
          Hide
          swinbank John Swinbank added a comment -

          Hey folks, I found this ticket hanging out which has been in review with no further commentary for 6 months. Simon Krughoff, is this on your todo list?

          Show
          swinbank John Swinbank added a comment - Hey folks, I found this ticket hanging out which has been in review with no further commentary for 6 months. Simon Krughoff , is this on your todo list?
          Hide
          Parejkoj John Parejko added a comment - - edited

          Pinging this one again Simon Krughoff: what do we do with it? You haven't commented on the PR.

          Show
          Parejkoj John Parejko added a comment - - edited Pinging this one again Simon Krughoff : what do we do with it? You haven't commented on the PR.
          Hide
          krughoff Simon Krughoff added a comment -

          I'm very sorry about letting this go. I'll get on it today.

          Show
          krughoff Simon Krughoff added a comment - I'm very sorry about letting this go. I'll get on it today.
          Hide
          krughoff Simon Krughoff added a comment -

          The question was what do we do with this. I suggest merging and closing this ticket. We should take a pass for untested code at some point in the relatively near future, but I don't see why that should hold this up.

          Show
          krughoff Simon Krughoff added a comment - The question was what do we do with this. I suggest merging and closing this ticket. We should take a pass for untested code at some point in the relatively near future, but I don't see why that should hold this up.
          Hide
          Parejkoj John Parejko added a comment -

          Thanks Simon Krughoff. Note that I messed up the master rebase somehow, resulting in PR 30 becoming a no-op. John Swinbank helped me recover from the reflog, and I made a new PR (43) and merged that.

          Show
          Parejkoj John Parejko added a comment - Thanks Simon Krughoff . Note that I messed up the master rebase somehow, resulting in PR 30 becoming a no-op. John Swinbank helped me recover from the reflog, and I made a new PR (43) and merged that.

            People

            • Assignee:
              cmorrison Chris Morrison
              Reporter:
              cmorrison Chris Morrison
              Reviewers:
              Simon Krughoff
              Watchers:
              Chris Morrison, John Parejko, John Swinbank, Simon Krughoff
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel