Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9861

lsstsw/bin/deploy git version check broken

    Details

    • Type: Story
    • Status: Invalid
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: Continuous Integration
    • Labels:
      None

      Description

      The git version check used by the deploy script is broken such that a local version of git will always been built. This check either needs to be fixed or removed.

        Attachments

          Activity

          Hide
          jhoblitt Joshua Hoblitt added a comment -

          The check appears to have been working as intended.

          Show
          jhoblitt Joshua Hoblitt added a comment - The check appears to have been working as intended.
          Show
          jhoblitt Joshua Hoblitt added a comment - Aww, they have a fork of the cookbook: https://github.com/travis-ci/travis-cookbooks/blob/precise-stable/ci_environment/git/recipes/ppa.rb
          Hide
          jhoblitt Joshua Hoblitt added a comment -

          I'm a bit puzzled as to how we are getting git 1.8 on travis. The packer template:

          https://github.com/travis-ci/packer-templates/blob/master/ci-standard.yml

          uses chef, which pulls in this cookbook:

          https://supermarket.chef.io/cookbooks/git_ppa/versions/0.1.2

          which configures this ppa:

          https://launchpad.net/~git-core/+archive/ubuntu/ppa

          Show
          jhoblitt Joshua Hoblitt added a comment - I'm a bit puzzled as to how we are getting git 1.8 on travis. The packer template: https://github.com/travis-ci/packer-templates/blob/master/ci-standard.yml uses chef, which pulls in this cookbook: https://supermarket.chef.io/cookbooks/git_ppa/versions/0.1.2 which configures this ppa: https://launchpad.net/~git-core/+archive/ubuntu/ppa
          Hide
          tjenness Tim Jenness added a comment -

          I'll add that deploy never builds git for me.

          Show
          tjenness Tim Jenness added a comment - I'll add that deploy never builds git for me.
          Hide
          jhoblitt Joshua Hoblitt added a comment -

          As it is always been built on travis CI and it didn't work for a test a did yesterday – but perhaps I fudged something. I just checked and travis is running 1.8.5.6 on precise. I would have sworn that precise had been upgraded to 1.9 – perhaps they downgraded?

          Show
          jhoblitt Joshua Hoblitt added a comment - As it is always been built on travis CI and it didn't work for a test a did yesterday – but perhaps I fudged something. I just checked and travis is running 1.8.5.6 on precise. I would have sworn that precise had been upgraded to 1.9 – perhaps they downgraded?
          Hide
          tjenness Tim Jenness added a comment -

          newinstall.sh uses the same logic (but strangely choosing a different reference git version).

          Show
          tjenness Tim Jenness added a comment - newinstall.sh uses the same logic (but strangely choosing a different reference git version).
          Hide
          tjenness Tim Jenness added a comment -

          What makes you think it's broken? Reproducing the logic on my mac suggests that the basic testing is fine:

          thrylos:~ $ GITVERNUM=$(git --version | cut -d\  -f 3)
          thrylos:~ $ GITVER=$(printf "%02d-%02d-%02d\n" $(echo "$GITVERNUM" | cut -d. -f1-3 | tr . ' '))
          thrylos:~ $ echo $GITVER
          02-12-00
          thrylos:~ $ if [[ $GITVER < "01-09-00" ]]; then echo old; fi
          thrylos:~ $ if [[ $GITVER < "03-09-00" ]]; then echo old; fi
          old
          

          Show
          tjenness Tim Jenness added a comment - What makes you think it's broken? Reproducing the logic on my mac suggests that the basic testing is fine: thrylos:~ $ GITVERNUM=$(git --version | cut -d\ -f 3) thrylos:~ $ GITVER=$(printf "%02d-%02d-%02d\n" $(echo "$GITVERNUM" | cut -d. -f1-3 | tr . ' ')) thrylos:~ $ echo $GITVER 02-12-00 thrylos:~ $ if [[ $GITVER < "01-09-00" ]]; then echo old; fi thrylos:~ $ if [[ $GITVER < "03-09-00" ]]; then echo old; fi old

            People

            • Assignee:
              jhoblitt Joshua Hoblitt
              Reporter:
              jhoblitt Joshua Hoblitt
              Watchers:
              Joshua Hoblitt, Tim Jenness
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel