Details
-
Type:
Story
-
Status: Invalid
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: Continuous Integration
-
Labels:None
-
Epic Link:
-
Team:SQuaRE
Description
The git version check used by the deploy script is broken such that a local version of git will always been built. This check either needs to be fixed or removed.
Attachments
Activity
newinstall.sh uses the same logic (but strangely choosing a different reference git version).
As it is always been built on travis CI and it didn't work for a test a did yesterday – but perhaps I fudged something. I just checked and travis is running 1.8.5.6 on precise. I would have sworn that precise had been upgraded to 1.9 – perhaps they downgraded?
I'll add that deploy never builds git for me.
I'm a bit puzzled as to how we are getting git 1.8 on travis. The packer template:
https://github.com/travis-ci/packer-templates/blob/master/ci-standard.yml
uses chef, which pulls in this cookbook:
https://supermarket.chef.io/cookbooks/git_ppa/versions/0.1.2
which configures this ppa:
Aww, they have a fork of the cookbook:
https://github.com/travis-ci/travis-cookbooks/blob/precise-stable/ci_environment/git/recipes/ppa.rb
The check appears to have been working as intended.
What makes you think it's broken? Reproducing the logic on my mac suggests that the basic testing is fine:
thrylos:~ $ GITVERNUM=$(git --version | cut -d\ -f 3)thrylos:~ $ GITVER=$(printf "%02d-%02d-%02d\n" $(echo "$GITVERNUM" | cut -d. -f1-3 | tr . ' '))thrylos:~ $ echo $GITVER02-12-00thrylos:~ $ if [[ $GITVER < "01-09-00" ]]; then echo old; fithrylos:~ $ if [[ $GITVER < "03-09-00" ]]; then echo old; fiold