Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9866

Make change to remove flagDecorator (RFC-302)

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_base
    • Labels:
      None
    • Story Points:
      1
    • Sprint:
      DRP S17-5, DRP S17-6
    • Team:
      Data Release Production

      Description

      This is a follow up to the FlagHandler modification DM-9249. Posted this last deletion to flagDecorator.py in case anyone unknown was using it.

        Attachments

          Issue Links

            Activity

            Hide
            pgee Perry Gee added a comment -

            OK, I'm done. It was just a bunch of little things. However, my impression is that no one is using ngmix, so we should probably make a choice. I think that for my work with Tony, we want to try to use some of Erin's algorithms, but not these two simplistic ones.

            Both meas_base and meas_extensions_ngmix can now be reviewed.

            I now seem to have more than one set of commits on meas_base. Not sure how to clean that up. But the last one, belonging to pgee2000@gmail.com, is the one I mean to merge after review.

            Show
            pgee Perry Gee added a comment - OK, I'm done. It was just a bunch of little things. However, my impression is that no one is using ngmix, so we should probably make a choice. I think that for my work with Tony, we want to try to use some of Erin's algorithms, but not these two simplistic ones. Both meas_base and meas_extensions_ngmix can now be reviewed. I now seem to have more than one set of commits on meas_base. Not sure how to clean that up. But the last one, belonging to pgee2000@gmail.com, is the one I mean to merge after review.
            Hide
            pgee Perry Gee added a comment -

            John, can I merge this one?

            Show
            pgee Perry Gee added a comment - John, can I merge this one?
            Hide
            swinbank John Swinbank added a comment -

            Sorry for being slow to get back to you.

            Could you please fix your e-mail address on the commits? You are still using "pgee2000.gmail.com", which isn't a valid address at all!

            Other than that, this looks fine. Thank you!

            Show
            swinbank John Swinbank added a comment - Sorry for being slow to get back to you. Could you please fix your e-mail address on the commits? You are still using "pgee2000.gmail.com", which isn't a valid address at all! Other than that, this looks fine. Thank you!
            Hide
            pgee Perry Gee added a comment -

            I did change this several days ago. And when I did so, I checked that git was able to identify me.

            My .gitconfig says
            [user]
            email = pgee2000@gmail.com

            Is there something else that has to be changed?

            Show
            pgee Perry Gee added a comment - I did change this several days ago. And when I did so, I checked that git was able to identify me. My .gitconfig says [user] email = pgee2000@gmail.com Is there something else that has to be changed?
            Hide
            swinbank John Swinbank added a comment -

            That configuration looks plausible, but your commits are still showing the incorrect address:

            $ git show | head -3
            commit 2cbf4d13248319aa69029cbef16c4d186a784223
            Author: Perry Gee <pgee2000.gmail.com>
            Date:   Tue Apr 18 16:31:06 2017 -0700
            

            Is it possible that you updated .gitconfig after you'd made the offending commit? If so, you will need to edit it to correct the address. Try:

            $ git commit --amend --reset-author
            

            (you will then need to force-push the result).

            Show
            swinbank John Swinbank added a comment - That configuration looks plausible, but your commits are still showing the incorrect address: $ git show | head -3 commit 2cbf4d13248319aa69029cbef16c4d186a784223 Author: Perry Gee <pgee2000.gmail.com> Date: Tue Apr 18 16:31:06 2017 -0700 Is it possible that you updated .gitconfig after you'd made the offending commit? If so, you will need to edit it to correct the address. Try: $ git commit --amend --reset-author (you will then need to force-push the result).

              People

              Assignee:
              pgee Perry Gee
              Reporter:
              pgee Perry Gee
              Reviewers:
              John Swinbank
              Watchers:
              Gregory Dubois-Felsmann, John Swinbank, Perry Gee
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.