Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9882

Add integrate interface to BoundedField/ChebyshevBoundedField

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw

      Description

      In order to implement the "mean zero point" functionality of PhotoCalib, I need to compute the integral over the bounding box. BoundedField does not include facilities for integration/differentiation. Fortunately, my primary usage is ChebyshevBoundedField, which has a relatively straight-forward recurrence relation for integration.

      I suggest an interface like the following on BoundedField, with a virtual "not implemented" default:

      // Compute the integral of this function over its bounding-box.
      double integrate() const;
      

        Attachments

          Issue Links

            Activity

            Hide
            Parejkoj John Parejko added a comment -

            Have to do this before I can finish DM-9192.

            Show
            Parejkoj John Parejko added a comment - Have to do this before I can finish DM-9192 .
            Hide
            Parejkoj John Parejko added a comment -

            Jim Bosch Thanks a lot for your help getting this together. Please let me know if you'd rather we have a third pair of eyes.

            Jonathan Sick I did an "interesting" thing with a test docstring and I'm curious to get your opinion on it. Specifically, see the docstring for testIntegrateBox, although there are changes to other docstrings that might be worth your look.

            Show
            Parejkoj John Parejko added a comment - Jim Bosch Thanks a lot for your help getting this together. Please let me know if you'd rather we have a third pair of eyes. Jonathan Sick I did an "interesting" thing with a test docstring and I'm curious to get your opinion on it. Specifically, see the docstring for testIntegrateBox , although there are changes to other docstrings that might be worth your look.
            Hide
            Parejkoj John Parejko added a comment -
            Show
            Parejkoj John Parejko added a comment - Jenkins run in progress: https://ci.lsst.codes/job/stack-os-matrix/22668/
            Hide
            jsick Jonathan Sick added a comment -

            Comment on the Mathematica code block at https://github.com/lsst/afw/pull/197/files#r108538321 tl;dr it won't work exactly, but it's not a big deal in practice.

            Show
            jsick Jonathan Sick added a comment - Comment on the Mathematica code block at https://github.com/lsst/afw/pull/197/files#r108538321 tl;dr it won't work exactly, but it's not a big deal in practice.
            Hide
            Parejkoj John Parejko added a comment -

            Thanks Jonathan Sick. I redid it as you suggested.

            Note: Jenkins run passed.

            Show
            Parejkoj John Parejko added a comment - Thanks Jonathan Sick . I redid it as you suggested. Note: Jenkins run passed.
            Hide
            jbosch Jim Bosch added a comment -

            Review complete. Comments on GitHub.

            Show
            jbosch Jim Bosch added a comment - Review complete. Comments on GitHub.
            Hide
            Parejkoj John Parejko added a comment -

            Thanks for the quick review! I believe I fixed all your comments.

            Merged and done.

            Show
            Parejkoj John Parejko added a comment - Thanks for the quick review! I believe I fixed all your comments. Merged and done.

              People

              • Assignee:
                Parejkoj John Parejko
                Reporter:
                Parejkoj John Parejko
                Reviewers:
                Jim Bosch
                Watchers:
                Jim Bosch, John Parejko, Jonathan Sick, Russell Owen, Simon Krughoff
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel