Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9885

Rename deepCoadd_srcMatch as deepCoadd_measMatch

    XMLWordPrintable

    Details

    • Story Points:
      1
    • Team:
      Data Release Production

      Description

      Implement RFC-306.

        Attachments

          Issue Links

            Activity

            No builds found.
            price Paul Price created issue -
            price Paul Price made changes -
            Field Original Value New Value
            Link This issue is triggered by RFC-306 [ RFC-306 ]
            Hide
            price Paul Price added a comment -

            And add srcMatchFull and deepCoadd_measMatchFull to the obs packages that don't have it.

            Show
            price Paul Price added a comment - And add srcMatchFull and deepCoadd_measMatchFull to the obs packages that don't have it.
            Hide
            price Paul Price added a comment -

            This has passed Jenkins (on the one system that didn't need to update ci_hsc during the Nebula downtime).

            Show
            price Paul Price added a comment - This has passed Jenkins (on the one system that didn't need to update ci_hsc during the Nebula downtime).
            Hide
            price Paul Price added a comment -

            Thanks for agreeing to review this, Maria Patterson [X]. I think you'll find it pretty straight-forward and repetitive, but mistakes may have slipped in so I appreciate your looking it over.

            Show
            price Paul Price added a comment - Thanks for agreeing to review this, Maria Patterson [X] . I think you'll find it pretty straight-forward and repetitive, but mistakes may have slipped in so I appreciate your looking it over.
            price Paul Price made changes -
            Reviewers Maria Patterson [ mtpatter ]
            Status To Do [ 10001 ] In Review [ 10004 ]
            Hide
            mtpatter Maria Patterson [X] (Inactive) added a comment -

            It looks like deepCoadd_srcMatch is still in two places in lsst-dm/pegasus_workflow, just searching Github. Do you want to do PRs for that too, if it should be updated? (Or make a ticket?)

            Show
            mtpatter Maria Patterson [X] (Inactive) added a comment - It looks like deepCoadd_srcMatch is still in two places in lsst-dm/pegasus_workflow, just searching Github. Do you want to do PRs for that too, if it should be updated? (Or make a ticket?)
            Hide
            price Paul Price added a comment -

            I know nothing about pegasus_workflow. Maybe Hsin-Fang Chiang does?

            Show
            price Paul Price added a comment - I know nothing about pegasus_workflow . Maybe Hsin-Fang Chiang does?
            Hide
            hchiang2 Hsin-Fang Chiang added a comment -

            Yes, I will update `pegasus_workflow`. Thanks for informing me!

            Show
            hchiang2 Hsin-Fang Chiang added a comment - Yes, I will update `pegasus_workflow`. Thanks for informing me!
            Hide
            hchiang2 Hsin-Fang Chiang added a comment -

            I added a corresponding PR in the pegasus_workflow and will merge it after other packages are merged.

            Show
            hchiang2 Hsin-Fang Chiang added a comment - I added a corresponding PR in the pegasus_workflow and will merge it after other packages are merged.
            Hide
            mtpatter Maria Patterson [X] (Inactive) added a comment -

            Ok, looks good. I got half way through commenting that the file template names were not updated before I realized that some of the PRs note that that is intentional. (Sorry!!!) Are they all intentionally left that way? Just triple checking. If that's all good for you, looks good by me.

            Show
            mtpatter Maria Patterson [X] (Inactive) added a comment - Ok, looks good. I got half way through commenting that the file template names were not updated before I realized that some of the PRs note that that is intentional. (Sorry!!!) Are they all intentionally left that way? Just triple checking. If that's all good for you, looks good by me.
            mtpatter Maria Patterson [X] (Inactive) made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            Hide
            price Paul Price added a comment -

            Thank you Maria Patterson [X]!

            I didn't touch the file templates on purpose, because I don't want to invalidate any of the existing data on disk. If people want to change them later, I'd support it, but it would take some organisation.

            Show
            price Paul Price added a comment - Thank you Maria Patterson [X] ! I didn't touch the file templates on purpose, because I don't want to invalidate any of the existing data on disk. If people want to change them later, I'd support it, but it would take some organisation.
            Hide
            price Paul Price added a comment -

            Merged to master.

            Show
            price Paul Price added a comment - Merged to master.
            price Paul Price made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            price Paul Price made changes -
            Component/s ci_hsc [ 13140 ]
            jbosch Jim Bosch made changes -
            Link This issue blocks DM-9907 [ DM-9907 ]

              People

              Assignee:
              price Paul Price
              Reporter:
              price Paul Price
              Reviewers:
              Maria Patterson [X] (Inactive)
              Watchers:
              Hsin-Fang Chiang, Maria Patterson [X] (Inactive), Paul Price
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.