Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9887

Wrap meas_mosaic with pybind11 instead of swig

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      This was not wrapped as part of DM-8467, but is now needed anyway.

        Attachments

          Activity

          Hide
          pschella Pim Schellart [X] (Inactive) added a comment -

          Preliminary wrapping complete but hard to test. Please test and report (or fix) any omissions.

          Show
          pschella Pim Schellart [X] (Inactive) added a comment - Preliminary wrapping complete but hard to test. Please test and report (or fix) any omissions.
          Hide
          jbosch Jim Bosch added a comment -

          Review complete; commits on PR.

          I have not tried running any data through, which is probably the only way to really test. We should probably ask Lauren MacArthur to do that after the initial testing on DM-9862 (off the last pre-pybind11 weekly) is done. We'll need to merge this to master and rebase DM-9862 on that before we merge that anyway.

          Show
          jbosch Jim Bosch added a comment - Review complete; commits on PR. I have not tried running any data through, which is probably the only way to really test. We should probably ask Lauren MacArthur to do that after the initial testing on DM-9862 (off the last pre-pybind11 weekly) is done. We'll need to merge this to master and rebase DM-9862 on that before we merge that anyway.
          Hide
          pschella Pim Schellart [X] (Inactive) added a comment -

          Thanks Jim Bosch! I sat with Lauren MacArthur yesterday. It is not fully bug free yet but we will continue to work on it on Friday. Should be close though. I was flying blind without unit tests to guide me here.

          Show
          pschella Pim Schellart [X] (Inactive) added a comment - Thanks Jim Bosch ! I sat with Lauren MacArthur yesterday. It is not fully bug free yet but we will continue to work on it on Friday. Should be close though. I was flying blind without unit tests to guide me here.
          Hide
          pschella Pim Schellart [X] (Inactive) added a comment -

          meas_mosaic now runs. But I don't know if the output makes sense. Per previous agreement I'll leave that up to Jim Bosch, Lauren MacArthur and or Bob Armstrong to check.

          Show
          pschella Pim Schellart [X] (Inactive) added a comment - meas_mosaic now runs. But I don't know if the output makes sense. Per previous agreement I'll leave that up to Jim Bosch , Lauren MacArthur and or Bob Armstrong to check.

            People

            • Assignee:
              pschella Pim Schellart [X] (Inactive)
              Reporter:
              pschella Pim Schellart [X] (Inactive)
              Reviewers:
              Jim Bosch, Lauren MacArthur
              Watchers:
              Jim Bosch, Lauren MacArthur, Pim Schellart [X] (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel