Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9889

makeWcs does not round-trip equinox and CoordSystem

    Details

    • Type: Bug
    • Status: Invalid
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Labels:
      None
    • Story Points:
      1
    • Team:
      Data Release Production
    • Urgent?:
      No

      Description

      The overload of afw::image::makeWcs that takes crval, crpix, and CD matrix elements calls the TanWcs constructor with many arguments defaulted, which can lead to incorrect results with older WCSs.

      It should probably also just return shared_ptr<TanWcs> instead of shared_ptr<Wcs>, since it always returns a TanWcs.

      The implementer of this ticket will undoubtedly also be frustrated by the fact that Wcs returns its CoordSystem via an enum but wants a string when it is constructed, and there's apparently no way to get the right string from an enum value. I'm hoping this can be addressed one way or another on this ticket as well.

        Attachments

          Issue Links

            Activity

            Hide
            jbosch Jim Bosch added a comment -

            There is also a small amount of code in meas_astrom's SipTransform.cc that should probably be cleaned up after these changes are made.

            Show
            jbosch Jim Bosch added a comment - There is also a small amount of code in meas_astrom's SipTransform.cc that should probably be cleaned up after these changes are made.
            Hide
            swinbank John Swinbank added a comment -

            This code was removed on DM-10765.

            Show
            swinbank John Swinbank added a comment - This code was removed on DM-10765 .

              People

              • Assignee:
                Unassigned
                Reporter:
                jbosch Jim Bosch
                Watchers:
                Jim Bosch, John Swinbank
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel