Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9940

Simplify package dependencies of template generation

    Details

    • Story Points:
      3
    • Sprint:
      Alert Production F17 - 10
    • Team:
      Alert Production

      Description

      The DCR matched template code has dependencies on sims packages that might be replaced with functionality from core software. Once DM-9615 is completed, some of these (such as the bandpass) may be obtained from the relevant obs package.

        Attachments

          Issue Links

            Activity

            Hide
            sullivan Ian Sullivan added a comment -

            I believe this actually blocks DM-9615, rather than being blocked by it. It will be much easier to stackify the prototype DCR code if it doesn't have to bring in new dependencies.

            Show
            sullivan Ian Sullivan added a comment - I believe this actually blocks DM-9615 , rather than being blocked by it. It will be much easier to stackify the prototype DCR code if it doesn't have to bring in new dependencies.
            Hide
            sullivan Ian Sullivan added a comment -

            This branch includes improvements to status messages for debugging, better dynamic convergence tests when working with real data, and removes the dependence on Bandpass from sims_photUtils. The filter profile approximation in BandpassHelper is of course not as accurate as using the measured filter profile from sims_photUtils, so the test results degraded slightly. There should be no need to compare the changes to any of the .npy test files.

            Show
            sullivan Ian Sullivan added a comment - This branch includes improvements to status messages for debugging, better dynamic convergence tests when working with real data, and removes the dependence on Bandpass from sims_photUtils. The filter profile approximation in BandpassHelper is of course not as accurate as using the measured filter profile from sims_photUtils, so the test results degraded slightly. There should be no need to compare the changes to any of the .npy test files.
            Hide
            cmorrison Chris Morrison added a comment -

            Small clarifications requested regarding a few magic numbers. Other than that code looks good.

            Show
            cmorrison Chris Morrison added a comment - Small clarifications requested regarding a few magic numbers. Other than that code looks good.
            Hide
            cmorrison Chris Morrison added a comment -

            Review points addressed and approved for merging assuming unittests and linting all pass.

            Show
            cmorrison Chris Morrison added a comment - Review points addressed and approved for merging assuming unittests and linting all pass.

              People

              • Assignee:
                sullivan Ian Sullivan
                Reporter:
                sullivan Ian Sullivan
                Reviewers:
                Chris Morrison
                Watchers:
                Chris Morrison, Ian Sullivan
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: