Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-995

Make NoiseReplacer a context manager

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Won't Fix
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_base
    • Labels:

      Description

      I think the API for NoiseReplacer could be made more idiomatic (and possibly safer) by turning it into a "context manager" (i.e. so it can be used with the "with" statement).

        Attachments

          Issue Links

          is duplicated by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-14226 Rewrite Noise Replacer as a context manager

          • In Progress

          Improvement - An improvement or enhancement to an existing feature or task. DM-3184 NoiseReplacer should be a context manager

          • Invalid

            Activity

            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Looked into doing this, decided it wasn't a good idea after all: while we could shoehorn NoiseReplacer into the Python context manager API, it isn't a natural fit.

            Show
            jbosch Jim Bosch added a comment - Looked into doing this, decided it wasn't a good idea after all: while we could shoehorn NoiseReplacer into the Python context manager API, it isn't a natural fit.

              People

              Assignee:
              jbosch Jim Bosch
              Reporter:
              jbosch Jim Bosch
              Watchers:
              Jim Bosch
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.