Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9952

Change our interpretation of FITS HDUs to be 0-indexed

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Labels:
      None
    • Team:
      DM Science

      Description

      See RFC-304.

      I'll do something to support the desire to keep -1 to mean "the last HDU", although I do not plan to support this now (a fits file doesn't declare how many HDUs it contains, so we'd have to count them). In C++ using the most negative int makes sense as the default value, and I assume that pybind11 can keep that as a default value.

        Attachments

          Issue Links

          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-304 Change interpretation of HDU for fits I/O routines

          • Implemented
          is triggering

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-10091 Fix problems left over from DM-9952

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-10206 Fix obs_decam compatibility with 0-indexed HDUs

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-9854 Disable code that skips an empty PDU when reading metadata

          • Won't Fix

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            rhl Robert Lupton added a comment -

            Lots of changes (30 files), but almost all are boilerplate 0 -> INT_MIN.

            Show
            rhl Robert Lupton added a comment - Lots of changes (30 files), but almost all are boilerplate 0 -> INT_MIN .
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Do you want the 2 open PRs reviewed (one in obs_base, one in afw)?

            Show
            Parejkoj John Parejko added a comment - Do you want the 2 open PRs reviewed (one in obs_base, one in afw)?
            Hide
            Permalink
            rhl Robert Lupton added a comment -

            Yes please. The obs_base one is pretty simple.

            Show
            rhl Robert Lupton added a comment - Yes please. The obs_base one is pretty simple.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            See (now completed) discussion on github.

            Show
            Parejkoj John Parejko added a comment - See (now completed) discussion on github.
            Hide
            Permalink
            rhl Robert Lupton added a comment -

            Merged to master, but I typoed the Jenkins run DM-9952 not tickets/DM-9952 and didn't notice failing tests from afwdata.

            Fixes on DM-10091

            Show
            rhl Robert Lupton added a comment - Merged to master, but I typoed the Jenkins run DM-9952 not tickets/ DM-9952 and didn't notice failing tests from afwdata. Fixes on DM-10091
            Hide
            Permalink
            mrawls Meredith Rawls added a comment -

            I just opened a PR on this ticket for obs_decam to make the ingestCalibs config work with HDU 0-indexing. It's a simple one-line fix. I requested John Parejko review it via GitHub even though I know he is out of town this week; if someone else involved in this ticket would rather review that would be fine too.

            Show
            mrawls Meredith Rawls added a comment - I just opened a PR on this ticket for obs_decam to make the ingestCalibs config work with HDU 0-indexing. It's a simple one-line fix. I requested John Parejko review it via GitHub even though I know he is out of town this week; if someone else involved in this ticket would rather review that would be fine too.
            Hide
            Permalink
            mrawls Meredith Rawls added a comment -

            My comment immediately above now refers to DM-10206, which was kindly reviewed by Colin Slater and has been merged.

            Show
            mrawls Meredith Rawls added a comment - My comment immediately above now refers to DM-10206 , which was kindly reviewed by Colin Slater and has been merged.

              People

              Assignee:
              rhl Robert Lupton
              Reporter:
              rhl Robert Lupton
              Reviewers:
              John Parejko
              Watchers:
              John Parejko, Meredith Rawls, Robert Lupton
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: