CLIPPED bit is being manually set in SafeClip and now CompareWarp. Remove these blocks when DM-9953 is complete:

https://github.com/lsst/pipe_tasks/commit/a1b2df812ae7b91836085ebea70598a41e9ca156

I'm adding some statistics (NCLIPPED, NMASKED), which Pim Schellart [X] may be interested in incorporating into his work.

Thanks for volunteering to look at this, Jim Bosch. There are commits in afw, obs_subaru and pipe_tasks. This includes stripping out background matching from assembleCoadd (because it was easy to do and has long been hanging over my head and it makes it easier to follow the code). I'm about to run this through Jenkins, but I've verified that a ci_hsc coadd's mask is what I expect.

Here's the i-band coadd from ci_hsc, with the CLIPPED pixels in white. The edges of the CCDs are showing up, along with pixels rejected in the coadd.

Looks good. One minor comment on how you may be able to slightly improve some test code.

But while this is all functional, I wonder if it's an abuse of CLIPPED for it to be used for EDGE pixels (and, to lesser extent, mask-rejected pixels). Since we can now add new mask planes without much cost, it might be a good idea to do so; something like:

• CLIPPED: one or more pixels going into the coadd was rejected by safe-clip or WarpCompare.
• REJECTED: one or more pixels going into the coadd was rejected by mask values set in processCcd.
• EDGE: one or more pixels going into the coadd was on the edge of a CCD
• INEXACT_PSF: CLIPPED | REJECTED | EDGE

One additional change in obs_sdss.

The modified version is starting to go green on Jenkins.

Merged to master.

I should explain the changes made after offline consultation with Jim:

• Pixels that are masked EDGE on the individual CCDs get masked SENSOR_EDGE on the coadd.
• Pixels that are clipped/rejected (there's no point distinguishing between the two because we don't do any rejection so as to avoid messing up the PSF) are masked CLIPPED on the coadd.
• Any pixel masked either SENSOR_EDGE or CLIPPED are also masked INEXACT_PSF.
• Added each of these to the PixelFlags measurement in both measureCoaddSources and forcedPhotCoadd.