Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9961

Add treecorr to validate_drp and lsst_ci dependencies

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: validate_drp
    • Labels:
      None

      Description

      Create a package for treecorr to allow for calculation of correlation functions in a fast, robust, and tested code.

      This will not add dependencies to lsst_apps or lsst_distrib.

      Implementation is likely
      1. Create wrapper install packages for treecorr.
      2. Figure out how to avoid adding the FITS reader dependency in treecorr.
      3. Add treecorr dependence to validate_drp table file.

      TreeCorr is a "[c]ode for efficiently computing 2-point and 3-point correlation functions" and is being proposed for use in validate_drp to calculate the correlation function of the PSF residual ellipticity (DM-8951). The GitHub repo is here:

      https://github.com/rmjarvis/TreeCorr

      TreeCorr depends on the following Python packages.

      numpy
      future
      fitsio
      pandas
      pyyaml
      cffi

        Attachments

          Issue Links

            Activity

            Hide
            wmwood-vasey Michael Wood-Vasey added a comment -

            In further discussion on RFC-296 Tim Jenness and Michael Wood-Vasey agreed to skip libffi and cffi and pin treecorr to v3.2.3 which has neither of those dependencies nor a pyfits dependency.

            Show
            wmwood-vasey Michael Wood-Vasey added a comment - In further discussion on RFC-296 Tim Jenness and Michael Wood-Vasey agreed to skip libffi and cffi and pin treecorr to v3.2.3 which has neither of those dependencies nor a pyfits dependency.
            Hide
            wmwood-vasey Michael Wood-Vasey added a comment -

            Collection of 4 PRs

            1. Create treecorr package.

            • This installs for me, but please double check that I did this right.

            Add treecorr to:
            2. lsstsw/etc/repos.yaml
            3. repos/etc/repos.yaml

            These above trivial one-line additions, but since Travis CI currently fails for these, it would make me feel better if you would double check.

            4. Add treecorr dependency to validate_drp.
            – Also trivial one-line addition.
            – I don't use treecorr in validate_drp yet as of this ticket. This just adds the dependency and clears the way for DM-8951.

            Show
            wmwood-vasey Michael Wood-Vasey added a comment - Collection of 4 PRs 1. Create treecorr package. This installs for me, but please double check that I did this right. Add treecorr to: 2. lsstsw/etc/repos.yaml 3. repos/etc/repos.yaml These above trivial one-line additions, but since Travis CI currently fails for these, it would make me feel better if you would double check. 4. Add treecorr dependency to validate_drp . – Also trivial one-line addition. – I don't use treecorr in validate_drp yet as of this ticket. This just adds the dependency and clears the way for DM-8951 .
            Hide
            tjenness Tim Jenness added a comment -

            Looks good to me. Not sure why the dependency needs to be added in this ticket but I'm not going to stop you doing that.

            Show
            tjenness Tim Jenness added a comment - Looks good to me. Not sure why the dependency needs to be added in this ticket but I'm not going to stop you doing that.
            Hide
            wmwood-vasey Michael Wood-Vasey added a comment -

            Thanks for the review, Tim Jenness

            Merged to master(s).

            Show
            wmwood-vasey Michael Wood-Vasey added a comment - Thanks for the review, Tim Jenness Merged to master(s).

              People

              • Assignee:
                wmwood-vasey Michael Wood-Vasey
                Reporter:
                wmwood-vasey Michael Wood-Vasey
                Reviewers:
                Tim Jenness
                Watchers:
                Michael Wood-Vasey, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel