Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-997

Test workaround in meas_base

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_base
    • Labels:
    • Team:
      Data Release Production

      Description

      Testing workaround in meas_base which may be the cause for asemi-random failure in one of the unit tests.

      Note: I wanted to test in a private u/rallsman/<xx> space but was unable to "git push origin u/rallsman/<xx>" due to hook reject.

      Note: I wanted to attach this Issue to the upcoming version 9.0 but was rejected since it wasn't pre-defined.

        Attachments

          Activity

          Hide
          jbosch Jim Bosch added a comment -

          Hmm, not sure what went wrong with your git privileges, but I'll take a look at committing a fix myself.

          Show
          jbosch Jim Bosch added a comment - Hmm, not sure what went wrong with your git privileges, but I'll take a look at committing a fix myself.
          Hide
          jbosch Jim Bosch added a comment -

          Fix (at least for my platform) is in on u/jbosch/DM-997.

          Problem is that random numbers were used in the test, without a consistent seed. I've just made it use a consistent seed.

          Show
          jbosch Jim Bosch added a comment - Fix (at least for my platform) is in on u/jbosch/ DM-997 . Problem is that random numbers were used in the test, without a consistent seed. I've just made it use a consistent seed.
          Hide
          robyn Robyn Allsman [X] (Inactive) added a comment - - edited

          Jim,
          I was trying to make it on a throw-away branch but that didn't work so I made my change on tickets/DM-997. I tested it in the stack with Perry's recommendation to use: random(1234). That rebuild worked up to ip_diffim so this did fix the meas_base problem – as you also verified.

          Do you care if it's seeded with 500 or 1234? I already have built with 1234 in the cluster stack and hopefully have AndyB testing ip_diffiim with that stack. However, none of this is in master yet so change is possible. It's your choice since it's now your ticket!

          You'll need takeover my ticket branch no matter what random number is chosen unless you (horrors) do the change directly on master.

          Show
          robyn Robyn Allsman [X] (Inactive) added a comment - - edited Jim, I was trying to make it on a throw-away branch but that didn't work so I made my change on tickets/ DM-997 . I tested it in the stack with Perry's recommendation to use: random(1234). That rebuild worked up to ip_diffim so this did fix the meas_base problem – as you also verified. Do you care if it's seeded with 500 or 1234? I already have built with 1234 in the cluster stack and hopefully have AndyB testing ip_diffiim with that stack. However, none of this is in master yet so change is possible. It's your choice since it's now your ticket! You'll need takeover my ticket branch no matter what random number is chosen unless you (horrors) do the change directly on master.
          Hide
          robyn Robyn Allsman [X] (Inactive) added a comment -

          The modification works;
          The implementation is crisp; and
          The specific unit test is successful.

          Show
          robyn Robyn Allsman [X] (Inactive) added a comment - The modification works; The implementation is crisp; and The specific unit test is successful.
          Hide
          robyn Robyn Allsman [X] (Inactive) added a comment -

          Jim, I reviewed this a long time ago and marked it Review Complete. Is this Issue Done?

          Show
          robyn Robyn Allsman [X] (Inactive) added a comment - Jim, I reviewed this a long time ago and marked it Review Complete. Is this Issue Done?
          Hide
          jbosch Jim Bosch added a comment -

          Yes, don't know how this escaped my notice earlier.

          Show
          jbosch Jim Bosch added a comment - Yes, don't know how this escaped my notice earlier.

            People

            • Assignee:
              jbosch Jim Bosch
              Reporter:
              robyn Robyn Allsman [X] (Inactive)
              Reviewers:
              Robyn Allsman [X] (Inactive)
              Watchers:
              Jim Bosch, Robyn Allsman [X] (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel