Jim Bosch added a comment - 31/Mar/17 7:50 PM Review complete, so I guess we'll use "In Review" to mean it's your turn to take a look at my comments? Mostly looks great! I've made lot of nitpicky stylistic comments, a few recommendations on name changes, and a few requests to move code from the headers to the source files. The C++ style guide is pretty dense and hard to internalize without a lot of experience in the stack (especially with so many bad examples in the old code we've never updated); I feel bad we didn't get you a reviewer with more experience earlier in this process to help you start to internalize it earlier. But hopefully this will help with that process, and it won't take too long to fix. And I certainly wouldn't object if you want to deal with a lot of the comments by just running clang-format.

Nate Lust added a comment - 27/Apr/17 11:51 AM This was a weird ordering on things, but this work was completed by me. The ticket can be closed now.