Uploaded image for project: 'Request For Comments'
  1. Request For Comments
  2. RFC-105

Update cfitsio to version that adds bz2 support

    XMLWordPrintable

    Details

    • Type: RFC
    • Status: Implemented
    • Resolution: Done
    • Component/s: DM
    • Labels:
      None
    • Location:
      PR

      Description

      Our current version of cfitsio is 3.36 (6 December 2013), while 3.37 (3 June 2014) adds support for bz2 files, which would make my #3033 life much easier. We should upgrade.

      Here's the changelog, for reference:

      http://heasarc.gsfc.nasa.gov/FTP/software/fitsio/c/docs/changes.txt

      NOTE: it appears the above statement is not true: 3.37 does not actually support bz2. This is being dealt with upstream. I've modified the title to better represent what this RFC actually is requesting: updating to whatever version actually does properly support bz2-compressed files (likely 3.38).

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-3033 Add Sdss3Mapper to ingest, convert and map SDSS-III "frame" files

          • Won't Fix
          is triggering

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. DM-6266 Upgrade cfitsio and deal with long keyword handling

          • Invalid

          Improvement - An improvement or enhancement to an existing feature or task. DM-4115 Update cfitsio to 3.37 (adding bz2 support)

          • Invalid
          relates to

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-640 Update CFITSIO to version 3.47 (aka 3470)

          • Implemented
          mentioned in

          Page Loading...

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            ktl Kian-Tat Lim added a comment -

            Can you please test first to see if anything bad might happen?

            Show
            ktl Kian-Tat Lim added a comment - Can you please test first to see if anything bad might happen?
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Jenkins build was successful:

            https://ci.lsst.codes/job/stack-os-matrix/label=centos-7/4828/

            Now to test whether this solves the bz2 problem.

            Show
            Parejkoj John Parejko added a comment - Jenkins build was successful: https://ci.lsst.codes/job/stack-os-matrix/label=centos-7/4828/ Now to test whether this solves the bz2 problem.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            It appears that 3.37 doesn't actually have working bz2 support. This is being dealt with upstream. Can I put this RFC on hold or something, while I wait to hear about the upstream fix?

            Show
            Parejkoj John Parejko added a comment - It appears that 3.37 doesn't actually have working bz2 support. This is being dealt with upstream. Can I put this RFC on hold or something, while I wait to hear about the upstream fix?
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            The title probably needs fixing. Either we say this is an RFC for 3.37 and just do the upgrade, or else we say it's an RFC to update cfitisio as soon as bz2 support is added. Either way the RFC can be adopted (the work on implementation is in another ticket).

            It's good to hear that someone is talking to Bill Pence about the issue (especially given the release notes stating that bz2 was included).

            Show
            tjenness Tim Jenness added a comment - The title probably needs fixing. Either we say this is an RFC for 3.37 and just do the upgrade, or else we say it's an RFC to update cfitisio as soon as bz2 support is added. Either way the RFC can be adopted (the work on implementation is in another ticket). It's good to hear that someone is talking to Bill Pence about the issue (especially given the release notes stating that bz2 was included).
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Good call. I've updated the title and added a note to the description.

            I'll adopt it tomorrow, assuming no one complains.

            Show
            Parejkoj John Parejko added a comment - Good call. I've updated the title and added a note to the description. I'll adopt it tomorrow, assuming no one complains.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            There are no complaints, and it looks like 3.38 will be released soon (private email) with a fix for this problem. Once that's out, I'll update DM-4115 with progress.

            Show
            Parejkoj John Parejko added a comment - There are no complaints, and it looks like 3.38 will be released soon (private email) with a fix for this problem. Once that's out, I'll update DM-4115 with progress.

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Watchers:
              Colin Slater, John Parejko, John Swinbank, Kian-Tat Lim, Simon Krughoff, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Planned End:

                  Jenkins

                  No builds found.