Uploaded image for project: 'Request For Comments'
  1. Request For Comments
  2. RFC-108

Make --show config=glob case insensitive

    XMLWordPrintable

    Details

    • Type: RFC
    • Status: Implemented
    • Resolution: Done
    • Component/s: DM
    • Labels:
      None
    • Location:
      PR

      Description

      The pipe_base parser supports

      --show config=PATTERN
      

      where PATTERN is a glob for the parameter you want to find. With the advent of documentation strings with the parameters this is no longer equivalent to piping the output to grep, so it's likely to see more use.

      One annoying feature is that glob matches are case sensitive, and you often want to look for a parameter without knowing it's case (Is it *Background*" or *background"?). There's a workaround (*[Bb]ackground*) but this is inconvenient.

      This RFC proposes making the match case insensitive. It's easy to do using fnmatch.translate, and I'm willing to do the work (i.e. push the patch and ask for a review)

        Attachments

          Issue Links

            Activity

            Hide
            ktl Kian-Tat Lim added a comment -

            OK by me.

            Show
            ktl Kian-Tat Lim added a comment - OK by me.
            Hide
            rowen Russell Owen added a comment -

            This sounds like a very useful improvement.

            Show
            rowen Russell Owen added a comment - This sounds like a very useful improvement.
            Hide
            swinbank John Swinbank added a comment -

            This RFC has implicitly been adopted and implemented by DM-4217. Can we mark it as such?

            Show
            swinbank John Swinbank added a comment - This RFC has implicitly been adopted and implemented by DM-4217 . Can we mark it as such?
            Hide
            ktl Kian-Tat Lim added a comment -

            Ping to the Assignee to close as suggested by John Swinbank.

            Show
            ktl Kian-Tat Lim added a comment - Ping to the Assignee to close as suggested by John Swinbank .
            Hide
            rhl Robert Lupton added a comment -

            Complete, implemented, and in use

            Show
            rhl Robert Lupton added a comment - Complete, implemented, and in use

              People

              Assignee:
              rhl Robert Lupton
              Reporter:
              rhl Robert Lupton
              Watchers:
              John Swinbank, Kian-Tat Lim, Robert Lupton, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Planned End:

                  Jenkins Builds

                  No builds found.