XMLWordPrintable

    Details

    • Type: RFC
    • Status: Implemented
    • Resolution: Done
    • Component/s: DM
    • Labels:
      None
    • Location:
      On this issue

      Description

      Edit: I'm trying to make it more clear what I consider in scope for the "base ISR."

      A milestone for this cycle is to deliver ISR to correct for all expected effects excluding those that involve pixel boundary distortions: brighter fatter, tree rings, edge rolloff, etc. The rationale is that we are still learning about the more subtle effects, but we need a basic ISR that will allow processing all data up to current levels. Below I outline three categories of effects.
      1. Effects in scope for "Base ISR" – I have put the things in bold that I think we need to spend some effort on.
      2. Effects that part of ISR, but out of scope for "Base ISR"
      3. Effects that are not part of ISR

      Effects in scope for "Base ISR"

      • Non-linearity correction
      • Intra-chip cross-talk correction
      • Basic defect and saturation interpolation
      • Dark current correction
      • Full frame bias correction
      • Overscan correction
      • Flatfielding
      • Illumination correction
      • Amp assembly
      • Fringe correction

      Effects in ISR, but out of scope for "Base ISR"

      • Brighter/Fatter
      • Treerings
      • Edge and midline rolloff
      • Pixel response non-uniformity
      • Hysteresis effects from bright stars
      • Charge transfer efficiency corrections
      • Inter-chip crosstalk
      • Advance defect and saturation interpolation (Gaussian processes?)

      Aspects that are out of scope for ISR

      • Cosmic ray mitigation
      • Persistence – My hope is this is handled by a higher level logging/orchestration framework
      • QA – We will need to instrument our tasks, but I think that's a different effort

        Attachments

          Issue Links

            Activity

            krughoff Simon Krughoff created issue -
            krughoff Simon Krughoff made changes -
            Field Original Value New Value
            Description A milestone for this cycle is to deliver ISR to correct for all expected effects excluding those that involve pixel boundary distortions: brighter fatter, tree rings, edge rolloff, etc. The rationale is that we are still learning about the more subtle effects, but we need a basic ISR that will allow processing all data up to current levels.

            What's missing?
            We do not currently have a working linearity correction. I plan to implement a simple one that will use the information in the ampInfo objects. There is a crosstalk correction that can possibly be ported from obs_subaru, but none exists in ip_isr at the mooment. I plan on implementing an intra-chip crosstalk solution. We will need something better, but probably not in the short term.

            I'm filing this RFC to make sure nothing else is missing. Current available corrections are:
             * Dark current correction
             * Full frame bias correction
             * Overscan correction
             * Flatfielding
             * Illumination correction
             * Amp assembly
             * Fringe correction

            Are there any others I should include?
            A milestone for this cycle is to deliver ISR to correct for all expected effects excluding those that involve pixel boundary distortions: brighter fatter, tree rings, edge rolloff, etc. The rationale is that we are still learning about the more subtle effects, but we need a basic ISR that will allow processing all data up to current levels.

            *What's missing?*
            We do not currently have a working linearity correction. I plan to implement a simple one that will use the information in the ampInfo objects. There is a crosstalk correction that can possibly be ported from obs_subaru, but none exists in ip_isr at the mooment. I plan on implementing an intra-chip crosstalk solution. We will need something better, but probably not in the short term.

            *What exists now.*
            I'm filing this RFC to make sure nothing else is missing. Current available corrections are:
             * Dark current correction
             * Full frame bias correction
             * Overscan correction
             * Flatfielding
             * Illumination correction
             * Amp assembly
             * Fringe correction

            Are there any others I should include?
            krughoff Simon Krughoff made changes -
            Description A milestone for this cycle is to deliver ISR to correct for all expected effects excluding those that involve pixel boundary distortions: brighter fatter, tree rings, edge rolloff, etc. The rationale is that we are still learning about the more subtle effects, but we need a basic ISR that will allow processing all data up to current levels.

            *What's missing?*
            We do not currently have a working linearity correction. I plan to implement a simple one that will use the information in the ampInfo objects. There is a crosstalk correction that can possibly be ported from obs_subaru, but none exists in ip_isr at the mooment. I plan on implementing an intra-chip crosstalk solution. We will need something better, but probably not in the short term.

            *What exists now.*
            I'm filing this RFC to make sure nothing else is missing. Current available corrections are:
             * Dark current correction
             * Full frame bias correction
             * Overscan correction
             * Flatfielding
             * Illumination correction
             * Amp assembly
             * Fringe correction

            Are there any others I should include?
            Edit: I'm trying to make it more clear what I consider in scope for the "base ISR."

            A milestone for this cycle is to deliver ISR to correct for all expected effects excluding those that involve pixel boundary distortions: brighter fatter, tree rings, edge rolloff, etc. The rationale is that we are still learning about the more subtle effects, but we need a basic ISR that will allow processing all data up to current levels. Below I outline three categories of effects.
             1. Effects in scope for "Base ISR" -- I have put the things in bold that I think we need to spend some effort on.
             2. Effects that part of ISR, but out of scope for "Base ISR"
             3. Effects that are not part of ISR

            *Effects in scope for "Base ISR"*
             * *Non-linearity correction*
             * *Intra-chip cross-talk correction*
             * Basic defect and saturation interpolation
             * Dark current correction
             * Full frame bias correction
             * Overscan correction
             * Flatfielding
             * *Illumination correction*
             * Amp assembly
             * *Fringe correction*

            *Effects in ISR, but out of scope for "Base ISR"*
             * Brighter/Fatter
             * Treerings
             * Edge and midline rolloff
             * Pixel response non-uniformity
             * Hysteresis effects from bright stars
             * Charge transfer efficiency corrections
             * Inter-chip crosstalk
             * Advance defect and saturation interpolation (Gaussian processes?)

            *Aspects that are out of scope for ISR*
             * Cosmic ray mitigation
             * Persistence -- My hope is this is handled by a higher level logging/orchestration framework
             * QA -- We will need to instrument our tasks, but I think that's a different effort
            krughoff Simon Krughoff made changes -
            Resolution Done [ 10000 ]
            Status Proposed [ 10805 ] Adopted [ 10806 ]
            tjenness Tim Jenness made changes -
            Link This issue is triggering DM-3878 [ DM-3878 ]
            swinbank John Swinbank made changes -
            Status Adopted [ 10806 ] Implemented [ 11105 ]

              People

              Assignee:
              krughoff Simon Krughoff
              Reporter:
              krughoff Simon Krughoff
              Watchers:
              Bob Armstrong, John Parejko, John Swinbank, Mario Juric, Michael Wood-Vasey, Paul Price, Robert Lupton, Simon Krughoff, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Planned End:

                  Jenkins

                  No builds found.