Uploaded image for project: 'Request For Comments'
  1. Request For Comments
  2. RFC-176

Add psutil to stack

    Details

    • Type: RFC
    • Status: Implemented
    • Resolution: Done
    • Component/s: DM
    • Labels:
      None
    • Location:
      This ticket.

      Description

      As part DM-5561 I have written an additional test case in lsst.utils.tests to check for leaks of file descriptors. To do this I use the psutil package from PyPI. It would be really useful if I could add psutil as a stack dependency. psutil seems to be very portable (python 2.6+, windows/solaris/linux/bsd/OSX) and has no dependencies.

      The two alternatives I have are:

      • Copy the code from meas_astrom/tests/openFiles.py which uses lsof and is not overly portable.
      • Only run the test if psutil is installed.

        Attachments

          Issue Links

            Activity

            Hide
            rowen Russell Owen added a comment -

            I think the new test is useful so I am in favor of this RFC. The fallback of only running the test if psutil is installed is, to me, an acceptable second best, as long as the code prints a warning that it will not run.

            Show
            rowen Russell Owen added a comment - I think the new test is useful so I am in favor of this RFC. The fallback of only running the test if psutil is installed is, to me, an acceptable second best, as long as the code prints a warning that it will not run.
            Hide
            ktl Kian-Tat Lim added a comment -

            Looks like a reasonable addition providing functionality beyond the standard resource package.

            Show
            ktl Kian-Tat Lim added a comment - Looks like a reasonable addition providing functionality beyond the standard resource package.
            Hide
            tjenness Tim Jenness added a comment -

            To be consistent with a couple of other packages I'll name it python_psutil.

            Show
            tjenness Tim Jenness added a comment - To be consistent with a couple of other packages I'll name it python_psutil .
            Hide
            tjenness Tim Jenness added a comment -

            No negative comments so I am adopting this RFC.

            Show
            tjenness Tim Jenness added a comment - No negative comments so I am adopting this RFC.

              People

              • Assignee:
                tjenness Tim Jenness
                Reporter:
                tjenness Tim Jenness
                Watchers:
                John Swinbank, Kian-Tat Lim, Russell Owen, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Planned End:

                  Summary Panel