Uploaded image for project: 'Request For Comments'
  1. Request For Comments
  2. RFC-212

Activate junk suppression by default

    XMLWordPrintable

    Details

    • Type: RFC
    • Status: Implemented
    • Resolution: Done
    • Component/s: DM
    • Labels:
      None

      Description

      SourceDetectionConfig.doTempLocalBackground currently defaults to False, but we have reason to believe that this should be True by default:

      • It suppresses junk in the wings of bright sources (e.g., compare without and with junk suppression).
      • It makes the deblender much more robust: processing the HSC data of the VVDS and HectoMap fields, I was seeing about half out of a hundred or so tracts fail in the deblender (usually a single patch in the tract blowing out the memory usage); when I turned on the junk suppression and re-ran, I saw only one tract fail, and that appears to be a bona fide deblender bug.
      • The only reason it's not activated by default is due to an oversight: the feature was introduced on the HSC side, where we intended to run with it on, but it was accidentally left disabled.

      If you're not familiar with this parameter, see HSC-1353, where it was introduced (under a different name).

      I propose to change the default behaviour to activate the junk suppression.

        Attachments

        1. rfc-212-1228-71.png
          rfc-212-1228-71.png
          511 kB
        2. rfc-212-brightstar.png
          rfc-212-brightstar.png
          480 kB
        3. rfc-212-satellite.png
          rfc-212-satellite.png
          695 kB

          Issue Links

            Activity

            price Paul Price created issue -
            price Paul Price made changes -
            Field Original Value New Value
            Attachment rfc-212-brightstar.png [ 28463 ]
            Attachment rfc-212-satellite.png [ 28464 ]
            price Paul Price made changes -
            Attachment rfc-212-1228-71.png [ 28473 ]
            price Paul Price made changes -
            Resolution Done [ 10000 ]
            Status Proposed [ 10805 ] Adopted [ 10806 ]
            price Paul Price made changes -
            Link This issue relates to DM-7525 [ DM-7525 ]
            price Paul Price made changes -
            Link This issue relates to DM-6815 [ DM-6815 ]
            price Paul Price made changes -
            Status Adopted [ 10806 ] Implemented [ 11105 ]
            lauren Lauren MacArthur made changes -
            Link This issue relates to DM-14935 [ DM-14935 ]

              People

              Assignee:
              price Paul Price
              Reporter:
              price Paul Price
              Watchers:
              Bob Armstrong, Jim Bosch, Lauren MacArthur, Paul Price, Robert Lupton, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Planned End:

                  Jenkins

                  No builds found.