Uploaded image for project: 'Request For Comments'
  1. Request For Comments
  2. RFC-237

Request for change to suprimecamMapper.paf

    Details

    • Type: RFC
    • Status: Implemented
    • Resolution: Done
    • Component/s: DM
    • Labels:
      None

      Description

      RFC for DM-7677: recommended changes to suprimecamMapper.paf file

      Request to modify some templates and dataset names to make the obs_*
      Mapper classes more consistent.

      DM-7049 was intended to make the Mapper datasets more consistent
      by centralizing datasets which could be shared across Mappers.
      The latest HscMapper.paf was used as a model. Datasets were moved
      to datasets.yaml and exposures.yaml in daf_butlerUtils.

      1. Datasets in the individual Mapper.paf which matched the shared
      ones in butlerUtils were deleted. To avoid changing any datasets
      deletion was only done on those matched in both name and content.
      Those which matched in name but not content are listed (1) below.

      2. Datasets were also flagged when it appeared that they could
      be shareable, but in fact were not in HscMapper at all. These
      are candidates to be renamed and moved to daf_butlerUtils.
      Some of these could also be datasets no longer in use.

      Please also see RFC-231 for datasets which are specifically
      connected to Coadd and Difference imaging. They were omitted
      from (2).
      -------------------------------------

      1. Datasets with same name but different content in suprimecamMapper.paf
      The difference is shown between the existing paf dataset and the
      proposed change to the "ref": the dataset is defined in butlerUtils.

      datasets.forcedPhotCcd_config
            python	lsst.pipe.tasks.forcedPhotCcd.ForcedPhotCcdConfig
        ref:python	lsst.meas.base.forcedPhotCcd.ForcedPhotCcdConfig
      datasets.deepCoadd_calexp_background
            template	deepCoadd-results/%(filter)s/%(tract)d/%(patch)s/b
                    	kgd-%(filter)s-%(tract)d-%(patch)s.fits
        ref:template	deepCoadd-results/%(filter)s/%(tract)d/%(patch)s/d
                    	et_bkgd-%(filter)s-%(tract)d-%(patch)s.fits
      datasets.mergeCoaddMeasurements_config
            python	lsst.pipe.tasks.multiBand.MergeSourcesConfig
        ref:python	lsst.pipe.tasks.multiBand.MergeMeasurementsConfig
      datasets.forced_src_schema
            template	schema/forced_src.fits
        ref:template	schema/forced_src_schema.fits
      

      -------------------------------------

      2. Datasets which should be examined to see if they should be
      removed, renamed, or moved to dafButlerUtils.
      Note mappers with the same dataset name are shown:
      l=lsstSim,d=decam,s=suprimecam,S=sdss,m=megacam,t=test

      datasets.deepCoad_calexpBackground: s
      datasets.deepCoadd_calexpBackground: s
      datasets.deepCoadd_extract: s
      datasets.deep_forcedPhotCoadd_config: s
      datasets.deep_forcedPhotCoadd_metadata: s
      datasets.multiband_config: smSl
      datasets.stack_config: s
      

      SuprimecamMapper also contains a bypass case for StackExposureId[_bits]
      which now may be outdated.

        Attachments

          Issue Links

            Activity

            Hide
            price Paul Price added a comment -

            For set (1), what is the ref? Is that what it is in obs_subaru, or what it will be when changed?

            For set (2), what is deepCoadd_extract? I don't recognise it. I think everything else should move except stack_config which I think is obsolete.

            StackExposureId* can be deleted.

            Show
            price Paul Price added a comment - For set (1), what is the ref ? Is that what it is in obs_subaru, or what it will be when changed? For set (2), what is deepCoadd_extract ? I don't recognise it. I think everything else should move except stack_config which I think is obsolete. StackExposureId* can be deleted.
            Hide
            pgee Perry Gee added a comment -

            I propose the following datasets be removed:

            datasets.stack_config:
            datasets.multiband_config:
            datasets.deepCoadd_extract:
            datasets.deepCoad_calexpBackground:
            datasets.deepCoadd_calexpBackground:

            remove the bypass for StackExposureId

            Show
            pgee Perry Gee added a comment - I propose the following datasets be removed: datasets.stack_config: datasets.multiband_config: datasets.deepCoadd_extract: datasets.deepCoad_calexpBackground: datasets.deepCoadd_calexpBackground: remove the bypass for StackExposureId
            Hide
            price Paul Price added a comment -

            Yes. I believe all of those are leftovers from HSC and have been replaced with LSST modern equivalents, so they can all go.

            Show
            price Paul Price added a comment - Yes. I believe all of those are leftovers from HSC and have been replaced with LSST modern equivalents, so they can all go.
            Hide
            pgee Perry Gee added a comment - - edited

            transformed_src_schema should be of type SourceCatalog

            ccdExposureId and _bits are have very odd storage: entries, which I propose that we change to "ignored"

            Remove deepCoadd override of "level"

            Show
            pgee Perry Gee added a comment - - edited transformed_src_schema should be of type SourceCatalog ccdExposureId and _bits are have very odd storage: entries, which I propose that we change to "ignored" Remove deepCoadd override of "level"
            Hide
            pgee Perry Gee added a comment -

            Implemented changes to this Mapper.paf from RFC-237

            Show
            pgee Perry Gee added a comment - Implemented changes to this Mapper.paf from RFC-237
            Hide
            swinbank John Swinbank added a comment -

            Perry Gee: I think this RFC is adopted, and will be implemented following the closure of DM-8128. Is that correct?

            Show
            swinbank John Swinbank added a comment - Perry Gee : I think this RFC is adopted, and will be implemented following the closure of DM-8128 . Is that correct?
            Hide
            pgee Perry Gee added a comment -

            Yes, that's correct. I may have missed this one.

            Show
            pgee Perry Gee added a comment - Yes, that's correct. I may have missed this one.
            Hide
            pgee Perry Gee added a comment -

            Work moved to DM-8128

            Show
            pgee Perry Gee added a comment - Work moved to DM-8128

              People

              • Assignee:
                pgee Perry Gee
                Reporter:
                pgee Perry Gee
                Watchers:
                Jim Bosch, John Parejko, John Swinbank, Paul Price, Perry Gee
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Planned End:

                  Summary Panel